Relax the service name validation to allow one char names

smithy-lang · Nov 16, 2023 · 79ad214 · 79ad214
1 parent e7f833d
commit 79ad214
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/SdkServiceIdValidator.java b/smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/SdkServiceIdValidator.java
@@ -114,8 +114,8 @@ public static void validateServiceId(String serviceId) {
             messages.add(String.format("Must not case-insensitively end with `%s`", suffix));
         });
 
-        if (serviceId.length() < 2 || serviceId.length() > 50) {
-            messages.add("Must be between 2 and 50 characters long.");
+        if (serviceId.isEmpty() || serviceId.length() > 50) {
+            messages.add("Must be between 1 and 50 characters long.");
         }
 
         if (!messages.isEmpty()) {

diff --git a/...aws-traits/src/test/java/software/amazon/smithy/aws/traits/SdkServiceIdValidatorTest.java b/...aws-traits/src/test/java/software/amazon/smithy/aws/traits/SdkServiceIdValidatorTest.java
@@ -76,16 +76,16 @@ public void noTrailingWhitespace() {
     @Test
     public void doesNotAllowShortIds() {
         IllegalArgumentException thrown = Assertions.assertThrows(IllegalArgumentException.class, () ->
-                SdkServiceIdValidator.validateServiceId("F"));
+                SdkServiceIdValidator.validateServiceId(""));
 
-        assertThat(thrown.getMessage(), containsString("2 and 50"));
+        assertThat(thrown.getMessage(), containsString("1 and 50"));
     }
 
     @Test
     public void doesNotAllowLongIds() {
         IllegalArgumentException thrown = Assertions.assertThrows(IllegalArgumentException.class, () ->
                 SdkServiceIdValidator.validateServiceId("Foobarbazqux Foobarbazqux Foobarbazqux Foobarbazqux"));
 
-        assertThat(thrown.getMessage(), containsString("2 and 50"));
+        assertThat(thrown.getMessage(), containsString("1 and 50"));
     }
 }