Add tests for quoted strings in headers

RFC 7230 sec 3.2.6 defines header values as potentially quoted strings, which makes commas in header values unambiguous. It's also the only way to escape a reserved character. This adds a test for list values with a comma and for list values with escaped double quotes.
smithy-lang · Nov 16, 2021 · 58c7c12 · 58c7c12
1 parent 4fd38fc
commit 58c7c12
Showing 1 changed file with 30 additions and 2 deletions.
diff --git a/smithy-aws-protocol-tests/model/restJson1/http-headers.smithy b/smithy-aws-protocol-tests/model/restJson1/http-headers.smithy
@@ -46,6 +46,21 @@ apply InputAndOutputWithHeaders @httpRequestTests([
             headerStringSet: ["a", "b", "c"],
         }
     },
+    {
+        id: "RestJsonInputAndOutputWithQuotedStringHeaders",
+        documentation: "Tests requests with string list header bindings that require quoting",
+        protocol: restJson1,
+        method: "POST",
+        uri: "/InputAndOutputWithHeaders",
+        headers: {
+            "X-StringList": """
+            "b,c","\"def\"",a"""
+        },
+        body: "",
+        params: {
+            headerStringList: ["b,c", "\"def\"", "a"]
+        }
+    },
     {
         id: "RestJsonInputAndOutputWithNumericHeaders",
         documentation: "Tests requests with numeric header bindings",
@@ -97,7 +112,7 @@ apply InputAndOutputWithHeaders @httpRequestTests([
         method: "POST",
         uri: "/InputAndOutputWithHeaders",
         headers: {
-            "X-TimestampList": "Mon, 16 Dec 2019 23:48:18 GMT, Mon, 16 Dec 2019 23:48:18 GMT"
+            "X-TimestampList": "\"Mon, 16 Dec 2019 23:48:18 GMT\", \"Mon, 16 Dec 2019 23:48:18 GMT\""
         },
         body: "",
         params: {
@@ -187,6 +202,19 @@ apply InputAndOutputWithHeaders @httpResponseTests([
             headerStringSet: ["a", "b", "c"],
         }
     },
+    {
+        id: "RestJsonInputAndOutputWithQuotedStringHeaders",
+        documentation: "Tests responses with string list header bindings that require quoting",
+        protocol: restJson1,
+        code: 200,
+        headers: {
+            "X-StringList": """
+            "b,c","\"def\"",a"""
+        },
+        params: {
+            headerStringList: ["a", "b,c", "\"def\""]
+        }
+    },
     {
         id: "RestJsonInputAndOutputWithNumericHeaders",
         documentation: "Tests responses with numeric header bindings",
@@ -233,7 +261,7 @@ apply InputAndOutputWithHeaders @httpResponseTests([
         protocol: restJson1,
         code: 200,
         headers: {
-            "X-TimestampList": "Mon, 16 Dec 2019 23:48:18 GMT, Mon, 16 Dec 2019 23:48:18 GMT"
+            "X-TimestampList": "\"Mon, 16 Dec 2019 23:48:18 GMT\", \"Mon, 16 Dec 2019 23:48:18 GMT\""
         },
         params: {
             headerTimestampList: [1576540098, 1576540098]