Allow enum shapes as resource identifiers

smithy-lang · Feb 28, 2023 · 2fa5aea · 2fa5aea
1 parent 86720ec
commit 2fa5aea
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/...del/src/main/java/software/amazon/smithy/model/validation/validators/TargetValidator.java b/...del/src/main/java/software/amazon/smithy/model/validation/validators/TargetValidator.java
@@ -219,7 +219,7 @@ private void validateMapKey(Shape shape, ShapeId target, Model model, List<Valid
     }
 
     private void validateIdentifier(Shape shape, Shape target, List<ValidationEvent> events) {
-        if (target.getType() != ShapeType.STRING) {
+        if (target.getType() != ShapeType.STRING && target.getType() != ShapeType.ENUM) {
             events.add(badType(shape, target, RelationshipType.IDENTIFIER, ShapeType.STRING));
         }
     }

diff --git a/.../amazon/smithy/model/errorfiles/validators/resource-identifiers/resource-identifiers.json b/.../amazon/smithy/model/errorfiles/validators/resource-identifiers/resource-identifiers.json
@@ -20,6 +20,14 @@
                 }
             ]
         },
+        "ns.foo#Valid2": {
+            "type": "resource",
+            "identifiers": {
+                "a": {
+                    "target": "ns.foo#MyEnum"
+                }
+            }
+        },
         "ns.foo#Invalid1": {
             "type": "resource",
             "identifiers": {
@@ -67,6 +75,17 @@
         },
         "ns.foo#MyString": {
             "type": "string"
+        },
+        "ns.foo#MyEnum": {
+            "type": "enum",
+            "members": {
+                "VALUE_1": {
+                    "target": "smithy.api#Unit",
+                    "traits": {
+                        "smithy.api#enumValue": "Value1"
+                    }
+                }
+            }
         }
     }
 }