feat: command classBuilder codegen #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
feat/commands
branch
9 times, most recently
from
3399d79 to
d872af6
Compare
8 tasks
kuhe
force-pushed
the
feat/commands
branch
5 times, most recently
from
4c8f1da to
d60afa0
Compare
kuhe
changed the title
trivikr
approved these changes
Dec 22, 2023
...est/java/software/amazon/smithy/typescript/codegen/endpointsV2/EndpointsV2GeneratorTest.java
Outdated
Show resolved
Hide resolved
...-codegen/src/test/java/software/amazon/smithy/typescript/codegen/StructureGeneratorTest.java
Outdated
Show resolved
Hide resolved
syall
approved these changes
Dec 22, 2023
trivikr
pushed a commit
to trivikr/smithy-typescript
that referenced
this pull request
Dec 27, 2023
* feat: command codegen * fix test * update ts pkg * wip * command class builder * fix: add check dependency script * rebase * empty changeset * update unit tests * remove unused import
kuhe
added a commit
to kuhe/smithy-typescript
that referenced
this pull request
Jan 3, 2024
* feat: command codegen * fix test * update ts pkg * wip * command class builder * fix: add check dependency script * rebase * empty changeset * update unit tests * remove unused import
kuhe
added a commit
to kuhe/smithy-typescript
that referenced
this pull request
Jan 4, 2024
* feat: command codegen * fix test * update ts pkg * wip * command class builder * fix: add check dependency script * rebase * empty changeset * update unit tests * remove unused import
kuhe
added a commit
to kuhe/smithy-typescript
that referenced
this pull request
Jan 4, 2024
* feat: command codegen * fix test * update ts pkg * wip * command class builder * fix: add check dependency script * rebase * empty changeset * update unit tests * remove unused import
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modifies command codegen have shorter output using the helper from #1118
associated codegen sample/sync: aws/aws-sdk-js-v3#5604
What is the effect on package size?
Using AWS SDK EC2 as an example, dist-cjs unpacked size went from 4.9 to 4.2 MB
What is the effect on initialization time?
This doesn't change the file count, so no meaningful change