Skip to content

fix: Fix silent failure with CRT HTTP client when response stream has an error #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sichanyoo merged 1 commit into from
Apr 15, 2025
Merged

fix: Fix silent failure with CRT HTTP client when response stream has an error #921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Sources/ClientRuntime/Networking/Http/CRT/CRTClientEngine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,14 +536,11 @@ public class CRTClientEngine: HTTPClient {
switch result {
case .success(let statusCode):
response.statusCode = makeStatusCode(statusCode)
stream.close()
case .failure(let error):
self.logger.error("Response encountered an error: \(error)")
continuation.safeResume(error: error)
stream.closeWithError(error)
}

// closing the stream is required to signal to the caller that the response is complete
// and no more data will be received in this stream
stream.close()
}

requestOptions.http2ManualDataWrites = http2ManualDataWrites
Expand Down
Loading