-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix request compression #3820
Fix request compression #3820
Conversation
A new generated diff is ready to view.
A new doc preview is ready to view. |
…ed-payload-content-length
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left minor comments, but LGTM!
...odegen/src/test/kotlin/software/amazon/smithy/rustsdk/HttpRequestCompressionDecoratorTest.kt
Outdated
Show resolved
Hide resolved
...odegen/src/test/kotlin/software/amazon/smithy/rustsdk/HttpRequestCompressionDecoratorTest.kt
Show resolved
Hide resolved
Co-authored-by: ysaito1001 <[email protected]>
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix and ship (Yuki's callout).
A new generated diff is ready to view.
A new doc preview is ready to view. |
Description
This PR includes several fixes for request compression:
aws_smithy_compression::body::compress::CompressedBody
will no longer incorrectly return the inner body'sSizeHint
, returningSizeHint::default()
instead.Testing
Tests are included. Additionally, I ran a reproducer for a user issues to ensure that their use case works:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.