Restore ENABLE_SMOKETESTS for running smoketests
#3799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aajtodd
approved these changes
Aug 23, 2024
Velfi
approved these changes
Aug 23, 2024
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
#3808) ## Motivation and Context Follow-up on #3799 ## Description This PR updates the smoke test rendering process for services whose models specify the `smokeTests` trait ([example](https://github.com/awslabs/aws-sdk-rust/blob/c349073b345a576d18ab7729afc7b75ae273d2ac/aws-models/sns.json#L3392-L3404)). Previously, `SmokeTestsDecorator` skipped rendering when `useAccountIdRouting` was set to true in the vendor parameters, which is the default for `AwsVendorParams`. Even though the Rust SDK does not currently support the account ID routing, it is safe to render these tests. This is because existing smoke tests do not rely on this feature, and when account ID routing is used, the Rust SDK will fall back to other means to sourcing the identity. This PR includes a minor fix: it uses `aws_config` to load default configurations. `config::Builder::new()` would have no credentials provider chain available, which would then result in test failures at runtime. ``` ---- test_list_certificates_success stdout ---- thread 'test_list_certificates_success' panicked at sdk/acm/tests/smoketests.rs:22:9: request should succeed: DispatchFailure(DispatchFailure { source: ConnectorError { kind: Other(None), source: NoMatchingAuthSchemeError(ExploredList { items: [ExploredAuthOption { scheme_id: AuthSchemeId { scheme_id: "sigv4" }, result: NoIdentityResolver }], truncated: false }), connection: Unknown } }) note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` By bringing `aws-config`, the `SmokeTestsDecoratorTest` no longer works, since the AWS runtime crates required by `aws-config` conflict with those generated by `awsSdkIntegrationTest` (a known limitation). For example: ``` error: package collision in the lockfile: packages aws-credential-types v1.2.0 (smithy-rs/aws/rust-runtime/aws-credential-types) and aws-credential-types v1.2.0 (smithy-rs/aws/sdk/build/aws-sdk/sdk/aws-credential-types) are different, but only one can be written to lockfile unambiguously ``` Therefore, we removed `SmokeTestsDecoratorTest.kt` _only_ in this PR to ship the feature, but are planning to restore it in the next PR by directly testing `SmokeTestsInstantiator` without using `awsSdkIntegrationTest`. ## Testing - [x] Existing tests in CI - [x] Executed and passed smoke tests for services that support them in our release pipeline ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR restores an environment variable we attempted to add in #3758.
Description
We removed that environment variable since we ran into an error
ENABLE_SMOKETESTS: unbound variablein our release pipeline. This PR will have a default valuefalsewhenENABLE_SMOKETESTSis not present.We expect the value to be
falsein smithy-rs CI andtruein our release pipeline (can set it totruein our release pipeline asynchronously).Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.