Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client-support for RPC v2 CBOR #3767

Merged
merged 20 commits into from
Jul 31, 2024
Merged

Add client-support for RPC v2 CBOR #3767

merged 20 commits into from
Jul 31, 2024

Commits on Jul 17, 2024

  1. Add client-support for rpcv2Cbor

    @ysaito1001
    ysaito1001 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b862dd6 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.next.toml

    @ysaito1001
    ysaito1001 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    dad444a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ysaito/smithy-rpc-v2-cbor-client-support

    @ysaito1001
    ysaito1001 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c8ef0e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Switch to Markdown syntax for links and add disclaimer 

    This commit addresses:
#3767 (comment)
#3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    840f61a View commit details
    Browse the repository at this point in the history

  2. Remove check that used to be necessary but isn't 

    This commit addresses #3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    21e1ab2 View commit details
    Browse the repository at this point in the history

  3. Add comment and unit test for timestamp truncation 

    This commit addresses #3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    4d0b0b5 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Avoid if when handling null for non-sparse collection 

    This commit addresses the following:
#3767 (comment)
#3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6699669 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Avoid if when determining setter wraps input with Some 

    This commit addresses #3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    4d24ece View commit details
    Browse the repository at this point in the history

  2. Use BuilderInstantiator to avoid explicit if 

    This commit addresses #3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ae02348 View commit details
    Browse the repository at this point in the history

  3. Let server protocol test generator use decode_body_data 

    This commit addresses
#3767 (comment)
#3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6ef41eb View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Return true from needsRequestContentLength in RpcV2Cbor 

    This commit addresses #3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6258fc4 View commit details
    Browse the repository at this point in the history

  2. Use T::from instead of .into() when turning into Enum 

    This commit addresses #3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    801af00 View commit details
    Browse the repository at this point in the history

  3. Add comment to cbor_errors::sanitize_error_code 

    This commit addresses #3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c9886c0 View commit details
    Browse the repository at this point in the history

  4. Revert adding entry to CHANGELOG.next.toml

    @ysaito1001
    ysaito1001 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    cb022eb View commit details
    Browse the repository at this point in the history

  5. Fix typo in the comment in needsRequestContentLength

    @ysaito1001
    ysaito1001 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6e1cafd View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Make comment for sanitize_error_code descriptive 

    This commit addresses #3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    0e153b3 View commit details
    Browse the repository at this point in the history

  2. Make needsRequestContentLength more accurate 

    This commit addresses #3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    4e70ca2 View commit details
    Browse the repository at this point in the history

  3. Add comments for lambdas passed to CborParserGenerator 

    This commit addresses #3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    56d39f4 View commit details
    Browse the repository at this point in the history

  4. Use DateTime::from_str to parse into expected value 

    This commit addresses #3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    54faaa7 View commit details
    Browse the repository at this point in the history

  5. Call out ErrorCorrection fix in CHANGELOG.next.toml 

    This commit addresses #3767 (comment)
    @ysaito1001
    ysaito1001 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    9acffc8 View commit details
    Browse the repository at this point in the history