Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set RUSTFLAGS environment variable when invoking Cargo commands via Gradle tasks #3678

Merged
merged 27 commits into from
Jun 21, 2024
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
d0f7448
Do not set `RUSTFLAGS` environment variable when invoking Cargo comma…
david-perez Jun 3, 2024
631a955
Merge branch 'main' into davidpz/do-not-set-rustflags-environment-var…
david-perez Jun 4, 2024
c7b242c
Clear RUSTDOCFLAGS
david-perez Jun 4, 2024
0dfd571
Fix some Clippy warnings
david-perez Jun 4, 2024
ee343d5
Fix more Clippy warnings
david-perez Jun 5, 2024
e3ad6cc
Add EOF newline to gradle.properties
david-perez Jun 5, 2024
c1060ef
Remove unnecessary semicolon
david-perez Jun 5, 2024
f891ab6
Fix fluent client docs
david-perez Jun 5, 2024
ec93443
Escape brackets in HTML elements' text
david-perez Jun 5, 2024
9cf2f0c
Dont reference types module if not generated
david-perez Jun 5, 2024
4e98dda
Comment out clearing RUSTDOCFLAGS
david-perez Jun 5, 2024
b0af582
Merge remote-tracking branch 'upstream/main' into davidpz/do-not-set-…
david-perez Jun 5, 2024
e75a6e0
Use [ instead of < in Smithy docs for misc.smithy
david-perez Jun 5, 2024
741d9ef
Unions are generated in the types module
david-perez Jun 5, 2024
1d249c2
./gradlew ktlintFormat
david-perez Jun 5, 2024
738f241
Fix doc warning when generating unions with unit variants
david-perez Jun 5, 2024
a6ed02b
Fix doc warning when referring to client methods with Rust reserved n…
david-perez Jun 5, 2024
d700dd4
Docs adjustment
david-perez Jun 5, 2024
dc67bc3
Allow broken intra doc links in server codegen integration tests temp…
david-perez Jun 5, 2024
cfbcba8
Fix cargo doc invocation
david-perez Jun 5, 2024
7d99365
./gradlew ktlintFormat
david-perez Jun 5, 2024
c35dc14
allow broken intra doc links in server codegen integration tests
david-perez Jun 6, 2024
2603634
Formatting
david-perez Jun 6, 2024
0d57bba
Merge remote-tracking branch 'upstream/main' into davidpz/do-not-set-…
david-perez Jun 21, 2024
81df348
Remove escape hatch to tolerate broken intra doc links
david-perez Jun 21, 2024
2c9d9f9
Fix Python
david-perez Jun 21, 2024
99f73ec
Fix Python now for real
david-perez Jun 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix Python now for real
david-perez committed Jun 21, 2024
commit 99f73ec83266e8ccba960b4f2b8e24b0de3ee9db
Original file line number Diff line number Diff line change
@@ -155,6 +155,7 @@ class PythonServerUnionGenerator(
if (member.isTargetUnit()) {
writer.rust(
"/// Tries to convert the enum instance into [`$variantName`](#T::$variantName), extracting the inner `()`.",
unionSymbol,
)
writer.rust("/// :rtype None:")
writer.rustBlockTemplate("pub fn as_$funcNamePart(&self) -> #{pyo3}::PyResult<()>", "pyo3" to pyo3) {