Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clippy lints from the future #3438

Merged
merged 6 commits into from
Feb 26, 2024
Merged

fix clippy lints from the future #3438

merged 6 commits into from
Feb 26, 2024

Conversation

Velfi
Copy link
Contributor

@Velfi Velfi commented Feb 22, 2024

Motivation and Context

Because the build pipeline is checking for these.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Velfi Velfi requested review from a team as code owners February 22, 2024 22:58
@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi marked this pull request as draft February 22, 2024 23:18
@Velfi
Copy link
Contributor Author

Velfi commented Feb 23, 2024

I keep running into "aws-smithy-mocks-experimental changed since release-2024-02-22 and requires a version bump". I'm surprised that it's triggering that because all I did was add a clippy allow.

@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi marked this pull request as ready for review February 23, 2024 17:38
@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi enabled auto-merge February 23, 2024 18:21
@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi disabled auto-merge February 23, 2024 19:49
@Velfi Velfi added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit 5b9d0c0 Feb 26, 2024
41 checks passed
@Velfi Velfi deleted the zhessler/fix-future-clippy-lints branch February 26, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysaito1001 ysaito1001 ysaito1001 approved these changes

@drganjoo drganjoo drganjoo approved these changes

@jdisanti jdisanti jdisanti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Velfi @jdisanti @drganjoo @ysaito1001