Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to disable S3 Express session auth #3433

Merged
merged 11 commits into from
Feb 27, 2024
Merged

Add support to disable S3 Express session auth #3433

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
65c1852
Add the abilty to disable S3 Express session auth
ysaito1001 Feb 16, 2024
dff3b2c
Add tests to verify disabling S3 Express session auth
ysaito1001 Feb 16, 2024
b756b31
Add TODO to convert an integ test to canary
ysaito1001 Feb 20, 2024
0be2aa0
Update the issue number for TODO
ysaito1001 Feb 21, 2024
39f7669
Register `S3ExpressRuntimePlugin` in `base_client_runtime_plugins`
ysaito1001 Feb 21, 2024
20068b2
Add a placeholder `should_panic` test
ysaito1001 Feb 23, 2024
f1cc4e8
Allow `AdditionalBaseClientPlugins` to contain statements
ysaito1001 Feb 23, 2024
3cdd811
Accept only `true` and `false` for env disabling S3 Express
ysaito1001 Feb 23, 2024
4eaab1b
Merge branch 'ysaito/s3express' into s3express-disable-session-auth
ysaito1001 Feb 27, 2024
77c5b97
Revert "Accept only `true` and `false` for env disabling S3 Express"
ysaito1001 Feb 27, 2024
f2c3445
Ignore env var and warn for any unexpected values
ysaito1001 Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions aws/rust-runtime/aws-inlineable/src/s3_express.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,6 +702,11 @@ pub(crate) mod runtime_plugin {
value,
)));
}
Ok(value) => {
ysaito1001 marked this conversation as resolved.
Show resolved Hide resolved
tracing::warn!("environment variable `{}` ignored since it only accepts either `true` or `false` (case-insensitive), but got `{}`.",
env::S3_DISABLE_EXPRESS_SESSION_AUTH,
value)
}
_ => {
// TODO(aws-sdk-rust#1073): Transfer a value of
// `s3_disable_express_session_auth` from a profile file to `layer`
Expand Down
Loading