Implement and test retry classifier sorting #3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test retry classifier sorting
|
I also fixed a few random things that IntelliJ didn't like. |
rcoh
reviewed
Feb 6, 2024
rust-runtime/aws-smithy-runtime-api/src/client/retries/classifiers.rs
Outdated
Show resolved
Hide resolved
| @@ -133,3 +134,141 @@ async fn test_retry_classifier_customization_for_operation() { | |||
| // ensure our custom retry classifier was called at least once. | |||
| assert_ne!(customization_test_classifier.counter(), 0); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
if we're going to put this in S3 (does it actually need to be?) then we should probably test actual S3 things if possible.
jdisanti
reviewed
Feb 7, 2024
fix Tracked<T> Ord and Eq implementations
hide sorting in runtime component build method
rcoh
approved these changes
Feb 7, 2024
rust-runtime/aws-smithy-runtime-api/src/client/retries/classifiers.rs
Outdated
Show resolved
Hide resolved
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
reviewed
Feb 7, 2024
rust-runtime/aws-smithy-runtime-api/src/client/retries/classifiers.rs
Outdated
Show resolved
Hide resolved
rust-runtime/aws-smithy-runtime-api/src/client/retries/classifiers.rs
Outdated
Show resolved
Hide resolved
…iers.rs Co-authored-by: John DiSanti <[email protected]>
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
approved these changes
Feb 8, 2024
jdisanti
reviewed
Feb 9, 2024
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Feb 9, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#3322
Description
I gave classifiers priorities but never actually sorted them. This PR fixes that.
Testing
I wrote a test
Checklist
CHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.