-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reexport EventReceiver
in a generated client crate
#3305
Merged
ysaito1001
merged 7 commits into
smithy-rs-release-1.x.y
from
ysaito/reexport-event-receiver
Dec 11, 2023
Merged
Reexport EventReceiver
in a generated client crate
#3305
ysaito1001
merged 7 commits into
smithy-rs-release-1.x.y
from
ysaito/reexport-event-receiver
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. At some point in the future, we can change this to use automatic re-export
A new generated diff is ready to view.
A new doc preview is ready to view. |
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adds re-export for
EventReceiver
in a generated client crateDescription
EventReceiver
was added in #3114 but the struct itself could not be referenced aspub
. Our SDK integration tests did not break in the said PR because they only called thenext
method on it and never referred to that struct name.This PR adds a re-export for
EventReceiver
in case customers need to refer to the name in their code.Testing
Added a unit test and edited a
transcribestreaming
integration test to verify the re-export.Checklist
CHANGELOG.next.toml
if I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.toml
if I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.