Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Stalled stream protection #3202

Merged
merged 27 commits into from
Nov 17, 2023
Merged

Feature: Stalled stream protection #3202

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
79bca6c
checkpoint
Velfi Nov 8, 2023
5569064
implement stalled stream protection for downloads
Velfi Nov 14, 2023
041a6dd
Merge remote-tracking branch 'origin/main' into zhessler-stalled-stre…
Velfi Nov 14, 2023
bc0965c
fix import that needed a feature gate
Velfi Nov 15, 2023
bf2040a
Merge branch 'main' into zhessler-stalled-stream-protection
Velfi Nov 15, 2023
48a42f2
fix doc test
Velfi Nov 15, 2023
cb63698
add CHANGELOG
Velfi Nov 15, 2023
d5e3cee
add grace period support
Velfi Nov 15, 2023
6cae978
remove feature gate
Velfi Nov 15, 2023
b7bce2f
Merge remote-tracking branch 'origin/main' into zhessler-stalled-stre…
Velfi Nov 15, 2023
d653f42
add allowed external type to aws-types
Velfi Nov 15, 2023
46920fa
add creds to integration tests
Velfi Nov 15, 2023
3e08632
Apply suggestions from code review
Velfi Nov 16, 2023
5a15468
Merge remote-tracking branch 'origin/main' into zhessler-stalled-stre…
Velfi Nov 16, 2023
b1f4149
remove config suffix from stalled stream function names
Velfi Nov 16, 2023
6d9a7e1
remove blob gate on stalled stream protection interceptor
Velfi Nov 16, 2023
a760a26
move stalled stream protection to runtime API crate
Velfi Nov 16, 2023
3dac27c
Merge branch 'main' into zhessler-stalled-stream-protection
Velfi Nov 16, 2023
f78c4f0
fix external types
Velfi Nov 16, 2023
25f9819
Merge branch 'main' into zhessler-stalled-stream-protection
Velfi Nov 16, 2023
6a52c90
fix dynamoDB retry tests
Velfi Nov 16, 2023
ed660ac
Merge branch 'main' of github.com:smithy-lang/smithy-rs into zhessler…
rcoh Nov 17, 2023
3ca242d
Fix bugs and tests
rcoh Nov 17, 2023
a0ab75a
Fix timestream
rcoh Nov 17, 2023
64f994a
Merge branch 'main' of github.com:smithy-lang/smithy-rs into zhessler…
rcoh Nov 17, 2023
c03f39b
Merge branch 'main' into zhessler-stalled-stream-protection
rcoh Nov 17, 2023
b257a71
Update CHANGELOG.next.toml
rcoh Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion aws/sdk/integration-tests/dynamodb/tests/retries-with-client-rate-limiting.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
* SPDX-License-Identifier: Apache-2.0
*/

use aws_sdk_dynamodb::config::{Credentials, Region, SharedAsyncSleep};
use aws_sdk_dynamodb::config::{
Credentials, Region, SharedAsyncSleep, StalledStreamProtectionConfig,
};
use aws_sdk_dynamodb::{config::retry::RetryConfig, error::ProvideErrorMetadata};
use aws_smithy_async::test_util::instant_time_and_sleep;
use aws_smithy_async::time::SharedTimeSource;
Expand Down Expand Up @@ -65,6 +67,7 @@ async fn test_adaptive_retries_with_no_throttling_errors() {

let http_client = StaticReplayClient::new(events);
let config = aws_sdk_dynamodb::Config::builder()
.stalled_stream_protection(StalledStreamProtectionConfig::new_disabled())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have to disable this in tests?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it because we're overriding sleep and the sleep is sleeping instantly?

.credentials_provider(Credentials::for_tests())
.region(Region::new("us-east-1"))
.retry_config(
Expand Down Expand Up @@ -120,6 +123,7 @@ async fn test_adaptive_retries_with_throttling_errors() {

let http_client = StaticReplayClient::new(events);
let config = aws_sdk_dynamodb::Config::builder()
.stalled_stream_protection(StalledStreamProtectionConfig::new_disabled())
.credentials_provider(Credentials::for_tests())
.region(Region::new("us-east-1"))
.retry_config(
Expand Down
Loading