Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the orchestrator vs. middleware benchmark #3158

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Delete the orchestrator vs. middleware benchmark #3158

merged 3 commits into from
Nov 10, 2023

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Nov 8, 2023

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti jdisanti requested a review from a team as a code owner November 8, 2023 23:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@rcoh
Copy link
Collaborator

rcoh commented Nov 9, 2023

why keep this around at all? isn't middleware dead?

@jdisanti
Copy link
Collaborator Author

jdisanti commented Nov 9, 2023

Yeah, fair enough. I can just delete it.

@jdisanti jdisanti changed the title Fix the orchestrator vs. middleware benchmark Delete the orchestrator vs. middleware benchmark Nov 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@jdisanti jdisanti enabled auto-merge November 9, 2023 18:07
@jdisanti jdisanti added this pull request to the merge queue Nov 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 9, 2023
@jdisanti jdisanti added this pull request to the merge queue Nov 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 9, 2023
@jdisanti jdisanti added this pull request to the merge queue Nov 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 10, 2023
@jdisanti jdisanti added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit 950d855 Nov 10, 2023
41 checks passed
@jdisanti jdisanti deleted the jdisanti-fix-middleware-benchmark branch November 10, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcoh rcoh rcoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdisanti @rcoh