Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crate guidance to match top-level guidance #3153

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Nov 8, 2023

Motivation and Context

Currently the guidance on the root repo doesn't match the guidance in the crates themselves.
Screenshot 2023-11-09 at 9 59 58 AM

Description

Update docs to match

Testing

  • post screenshot of docs once they're generated

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested a review from a team as a code owner November 8, 2023 17:50
Copy link

github-actions bot commented Nov 8, 2023

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@rcoh rcoh added the needs-backport needs to be merged back into the main branch label Nov 9, 2023
@rcoh rcoh added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit a69c346 Nov 9, 2023
@rcoh rcoh deleted the prod-guidance branch November 9, 2023 15:36
rcoh added a commit that referenced this pull request Nov 13, 2023
## Motivation and Context
Currently the guidance on the root repo doesn't match the guidance in
the crates themselves.
<img width="989" alt="Screenshot 2023-11-09 at 9 59 58 AM"
src="https://github.com/awslabs/smithy-rs/assets/492903/fdd11ffa-bf90-4ddc-897e-c5d5572e8c75">

## Description
Update docs to match
## Testing
- [x] post screenshot of docs once they're generated
----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
rcoh added a commit that referenced this pull request Nov 13, 2023
## Motivation and Context
Currently the guidance on the root repo doesn't match the guidance in
the crates themselves.
<img width="989" alt="Screenshot 2023-11-09 at 9 59 58 AM"
src="https://github.com/awslabs/smithy-rs/assets/492903/fdd11ffa-bf90-4ddc-897e-c5d5572e8c75">

## Description
Update docs to match
## Testing
- [x] post screenshot of docs once they're generated
----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport needs to be merged back into the main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants