-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum throughput body timeouts Pt.1 #3068
Merged
Merged
Changes from 10 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
6052d0b
add updated minimum throughput body and tests
Velfi 10d7c6f
Merge branch 'main' into zhessler-minimum-throughput-body
Velfi 299cdd1
update minimum throughput body tests
Velfi 61b3e8d
update minimum throughput body
Velfi f48be94
update MTB such that it works correctly when polled only once
Velfi 24c5e7a
remove ByteStream::taken
Velfi 900e9c8
Merge branch 'main' into zhessler-minimum-throughput-body
Velfi 4c5d4b8
make MTB futuristic
Velfi 2c42b2a
Merge branch 'main' into zhessler-minimum-throughput-body
Velfi b322525
update minimum throughput body tests
Velfi 0fe952e
update minimum throughput body logging
Velfi 66cfa44
fix clippy lints
Velfi 5b3c0d6
remove use of deprecated alias
Velfi 9488a1f
Merge branch 'main' into zhessler-minimum-throughput-body
Velfi 98ce003
add http_body external type to allow list
Velfi 0761d13
add shrinking sine wave test
Velfi b3d8a32
Merge branch 'main' into zhessler-minimum-throughput-body
Velfi 43455b1
make the Sleep future Sync again
Velfi 85c7b1a
Merge branch 'main' into zhessler-minimum-throughput-body
Velfi 1fb22fc
update MTB based on PR feedback
Velfi f7da9a4
fix doc link errors
Velfi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,4 @@ | ||
[workspace] | ||
|
||
|
||
members = [ | ||
"inlineable", | ||
"aws-smithy-async", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
pub mod minimum_throughput; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Futures shouldn't be
Sync
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After talking with Carl, I decided that this future should in fact be sync. While we could wrap this future in a mutex or similar to make it
Sync
, I'm opting to just add the bound. The reasoning is that omitting theSync
bound will cause more user pain than including it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requiring a future to be
Sync
can cause some issue when used with an async block (lang forum), but I don't necessarily see how that bites us here 🤔At least, I think this PR needs a label
breaking-change
becauseSleep::new
now fails to take an async block for certain cases (playground - derived from the above lang forum).