Omit fractional seconds from http-date format
#2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doesn't need to be in this PR, but we should also add an S3-specific protocol test for awslabs/aws-sdk-rust#818 Can you also link to aws-sdk-rust#818 from the changelog? It would be good to also verify that that API actually works after this change. We should also contribute a protocol test upstream that mandates this behavior—currently there are non that I'm aware of. |
rcoh
approved these changes
Sep 19, 2023
jdisanti
reviewed
Sep 20, 2023
rcoh
requested changes
Sep 20, 2023
CHANGELOG.next.toml
Outdated
| @@ -150,3 +150,9 @@ message = "Fix regression with redacting sensitive HTTP response bodies." | |||
| references = ["smithy-rs#2926", "smithy-rs#2972"] | |||
| meta = { "breaking" = false, "tada" = false, "bug" = true, "target" = "client" } | |||
| author = "ysaito1001" | |||
|
|
|||
| [[smithy-rs]] | |||
| message = "Omit fractional seconds from `date-time` format." | |||
There was a problem hiding this comment.
Suggested change
| message = "Omit fractional seconds from `date-time` format." | |
| message = "Omit fractional seconds from `http-date` format." |
| @@ -309,7 +309,7 @@ mod tests { | |||
| object.finish(); | |||
|
|
|||
| assert_eq!( | |||
| r#"{"epoch_seconds":5.2,"date_time":"2021-05-24T15:34:50.123Z","http_date":"Wed, 21 Oct 2015 07:28:00 GMT"}"#, | |||
| r#"{"epoch_seconds":5.2,"date_time":"2021-05-24T15:34:50Z","http_date":"Wed, 21 Oct 2015 07:28:00 GMT"}"#, | |||
There was a problem hiding this comment.
We should change this test to put a fraction in http_date—and I think we need to back out the changes to date_time, only http_date omits the subsecond. My bad on that—good catch from @jdisanti
rschmitt
changed the title
date-time formathttp-date format
rcoh
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #2831.
Description
Fractional seconds will still be accepted during parsing, but not emitted during serialization.
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.