Use the default(..) trait to source default information #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
force-pushed
the
trait-driven-defaults
branch
from
059aa70 to
16e8771
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
reviewed
Sep 12, 2023
rcoh
force-pushed
the
trait-driven-defaults
branch
from
16e8771 to
841afc2
Compare
No, I wouldn't expect there to be—this change is only load-bearing in combination with #1767 |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
trait-driven-defaults
branch
from
841afc2 to
1f08e01
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Because of Smithy IDL v1 semantics, we were incorrectly providing generalized default values. This isn't correct in Smithy IDLv2 where the
defaulttrait controls default behavior.Description
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.