Add ability to yank different crate sets to the publisher tool #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
force-pushed
the
jdisanti-partial-yank
branch
from
8d49a5b to
eeecfbe
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
reviewed
Aug 21, 2023
Comment on lines
+23
to
+32
| #[derive(Copy, Clone, Debug, ArgEnum, Eq, PartialEq, Ord, PartialOrd)] | ||
| pub enum CrateSet { | ||
| /// (default) Yank all crates associated with the release. | ||
| All, | ||
| /// Yank all AWS SDK crates. | ||
| AllAwsSdk, | ||
| /// Yank generated AWS SDK crates. | ||
| GeneratedAwsSdk, | ||
| } | ||
|
|
There was a problem hiding this comment.
Just to make sure I understand correctly:
All: AWS SDKs, AWS runtime crates, smithy runtime cratesAllAwsSdk: AWS SDKs, AWS runtime cratesGeneratedAwsSdk: AWS SDKs
Is that correct?
Velfi
reviewed
Aug 21, 2023
| .tag | ||
| .as_ref() | ||
| .ok_or_else(|| { | ||
| anyhow!("Versions manifest doesn't have a release tag. Can only yank tagged releases.") |
There was a problem hiding this comment.
In what cases could this occur? If we did a manual release and never tagged it?
There was a problem hiding this comment.
It can happen if you download a generated SDK from CI or something and try to yank with its version.toml.
Velfi
reviewed
Aug 21, 2023
| info!("This will yank aws-sdk-rust's `{tag}` release from crates.io."); | ||
| info!("Crates to yank:"); | ||
| for (crate_name, crate_version) in &release.crates { | ||
| for (crate_name, crate_version) in crates { | ||
| info!(" {}-{}", crate_name, crate_version); |
There was a problem hiding this comment.
Feel free to ignore this since you didn't touch this line.
Suggested change
| info!(" {}-{}", crate_name, crate_version); | |
| info!("\t{}-{}", crate_name, crate_version); |
We should use tab characters instead of spaces for stuff like this.
Velfi
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds different crate sets to the publisher tool so that different groups of crates can be yanked rather than yanking everything.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.