ban mio dependency so we don't accidentally break WASM users #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
Putting this on hold since I couldn't figure it out in a short time. |
simbleau
reviewed
Aug 15, 2023
| @@ -34,7 +37,7 @@ http = "0.2.9" | |||
| http-body = "0.4.5" | |||
| md-5 = "0.10.1" | |||
| ring = "0.16" | |||
| tokio = { version = "1.23.1", features = ["full"] } | |||
| tokio = { version = "1.23.1" } | |||
There was a problem hiding this comment.
I think you need default-features = false here. I'm not sure that the default-features are wasm-compat, and I wouldn't count on it.
There was a problem hiding this comment.
this cargo.toml isn't actually used in anything
simbleau
reviewed
Aug 15, 2023
| @@ -47,6 +50,7 @@ aws-smithy-runtime-api = { path = "../../../rust-runtime/aws-smithy-runtime-api" | |||
| tempfile = "3.6.0" | |||
| tracing-subscriber = { version = "0.3.17", features = ["env-filter"] } | |||
| aws-smithy-async = { path = "../../../rust-runtime/aws-smithy-async", features = ["test-util"] } | |||
| tokio = { version = "1.23.1", features = ["rt", "macros"] } | |||
There was a problem hiding this comment.
Same here, needs default-features = false
simbleau
reviewed
Aug 15, 2023
| @@ -19,5 +19,5 @@ aws-sdk-s3 = { path = "../../build/aws-sdk/sdk/s3", default-features = false } | |||
| aws-smithy-async = { path = "../../build/aws-sdk/sdk/aws-smithy-async" } | |||
| aws-credential-types = { path = "../../build/aws-sdk/sdk/aws-credential-types", features = ["test-util"] } | |||
| futures = "0.3.25" | |||
| tokio = { version = "1.23.1", features = ["full", "test-util"] } | |||
| tokio = { version = "1.23.1", features = ["macros", "test-util"] } | |||
simbleau
reviewed
Aug 15, 2023
| @@ -47,7 +47,7 @@ aws-smithy-async = { path = "../aws-smithy-async", features = ["rt-tokio"] } | |||
| hyper-tls = { version = "0.5.0" } | |||
| serde = { version = "1", features = ["derive"] } | |||
| serde_json = "1" | |||
| tokio = { version = "1.23.1", features = ["full", "test-util"] } | |||
| tokio = { version = "1.23.1", features = ["macros", "test-util"] } | |||
simbleau
suggested changes
Aug 15, 2023
There was a problem hiding this comment.
The only features that are wasm-compat for wasm32-unknown-unknown are:
sync
macros
io-util
rt
time
https://docs.rs/tokio/latest/tokio/#wasm-support
The default features are seemingly not wasm-compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we bring in
mio, it breaks WASM users. We don't currently have a need formioso I've added a ban so that we don't accidentally bring it in.This change also
async-traitwe're using so that we don't bring in two versions ofsyn.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.