Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated summary docs for convenience HashMap / Vec members #2914

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Aug 9, 2023

Previously the docs said Vec<String> when the method actually accepted String, similarly for HashMap.

Motivation and Context

Description

Fix the generator to be aware of Vec/Hashmap methods

Testing

  • UT
  • audit codegen diff

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested review from a team as code owners August 9, 2023 19:13
Copy link
Contributor

@Velfi Velfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for adding a test too

Previously the docs said `Vec<String>` when the method actually accepted `String`, similarly for HashMap.
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

A new generated diff is ready to view.

A new doc preview is ready to view.

@rcoh rcoh enabled auto-merge August 14, 2023 15:54
@rcoh rcoh added this pull request to the merge queue Aug 14, 2023
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Merged via the queue into main with commit 17e78b6 Aug 14, 2023
42 checks passed
@rcoh rcoh deleted the fix-summary-docs branch August 14, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants