Add get_foo() -> &Option<Foo> accessors for builders and fluent builders. #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidSouther
force-pushed
the
dev/builder/inner_getter
branch
2 times, most recently
from
5f289cd to
5a0c721
Compare
jdisanti
reviewed
Jun 20, 2023
...software/amazon/smithy/rust/codegen/client/smithy/generators/client/FluentClientGenerator.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/generators/BuilderGenerator.kt
Outdated
Show resolved
Hide resolved
...ware/amazon/smithy/rust/codegen/client/smithy/generators/client/FluentClientGeneratorTest.kt
Outdated
Show resolved
Hide resolved
DavidSouther
force-pushed
the
dev/builder/inner_getter
branch
from
2fb6e93 to
14647fa
Compare
…ers. This allows testing, as well as making decisions while creating builders. The references are not mutable, so these props remain read only keeping the Builder invariants.
DavidSouther
force-pushed
the
dev/builder/inner_getter
branch
from
14647fa to
c25217d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows testing, as well as making decisions while creating builders. The references are not mutable, so these props remain read only keeping the Builder invariants.
Motivation and Context
Some operations are built up using various logic (for instance, choosing an S3 bucket based on a logged in user). It is a lot of overhead to test at the mock level, and the Debug formatting is typically not stable.
Closes #2791
Description
get_foo(&self) -> &Option<Foo>to Buildersas_input(&self) -> &OperationInputBuilderto Fluent Buildersget_foo(&self) -> &Option<Foo>to FluentBuilder which delegates to BuildersTesting
Included unit tests, as well as proof of concept tests
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.