-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update retry classifiers to act on InterceptorContext instead of OrchestratorError #2737
Merged
Velfi
merged 8 commits into
main
from
update/retry-classifiers-and-interceptor-context-methods
Jun 1, 2023
Merged
Update retry classifiers to act on InterceptorContext instead of OrchestratorError #2737
Velfi
merged 8 commits into
main
from
update/retry-classifiers-and-interceptor-context-methods
Jun 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add codegen method for inserting retry classifiers into the config bag update `InterceptorContext` to return options instead of panicking
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
reviewed
May 31, 2023
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
reviewed
May 31, 2023
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
InterceptorContext
InterceptorContext
to return options instead of panickingTesting
Tests were updated as needed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.