Integrate TimeSource into the orchestrator and middleware (breaking change warning is spurious) #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
force-pushed
the
timesource-integration
branch
2 times, most recently
from
d0a8f56
to
c976824
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
timesource-integration
branch
from
c976824
to
1b93e91
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
timesource-integration
branch
3 times, most recently
from
9cd150e
to
5a4ab98
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
timesource-integration
branch
from
dd21d51
to
487c85d
Compare
rcoh
force-pushed
the
timesource-integration
branch
from
487c85d
to
8d48851
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
May 25, 2023
| #[derive(Debug, Clone)] | ||
| // TODO(breakingChangeWindow): Delete this struct |
There was a problem hiding this comment.
Should we also add #[deprecated]? You can also probably just remove it now...
| fn set_request_time(&mut self, request_time: RequestTime) { | ||
| self.put::<RequestTime>(request_time); | ||
| fn set_request_time(&mut self, request_time: impl TimeSource + 'static) { | ||
| self.put::<SharedTimeSource>(SharedTimeSource::new(request_time)); |
There was a problem hiding this comment.
Does this end up being a Box<Arc<...>> under the hood due to the ConfigBag implementation?
There was a problem hiding this comment.
yeah (but so does every thing we put in the ConfigBag, unfortunately)
there is a little trickery we could do to avoid that double-allocation with the new load/store traits because they can offer an enum that exposes the internals of the object so the config bag can use the smart pointer directly. not sure if it's worth it
ysaito1001
reviewed
May 26, 2023
| @@ -70,7 +72,7 @@ class CustomizableOperationTestHelpers(runtimeConfig: RuntimeConfig) : | |||
| pub fn request_time_for_tests(mut self, request_time: ::std::time::SystemTime) -> Self { | |||
| use #{ConfigBagAccessors}; | |||
| let interceptor = #{TestParamsSetterInterceptor}::new(move |_: &mut #{BeforeTransmitInterceptorContextMut}<'_>, cfg: &mut #{ConfigBag}| { | |||
| cfg.set_request_time(#{RequestTime}::new(request_time)); | |||
| cfg.set_request_time(#{StaticTimeSource}::new(request_time)); | |||
There was a problem hiding this comment.
Is StaticTimeSource available in codegenScope?
rcoh
force-pushed
the
timesource-integration
branch
from
8d48851
to
a15fb24
Compare
rcoh
changed the title
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
2 tasks
1 task
jdisanti
pushed a commit
that referenced
this pull request
Jun 16, 2023
…mode (#2762) ## Motivation and Context Service config structs now only contain a `aws_smithy_types::config_bag::FrozenLayer` in the orchestrator mode (no changes for the middleware mode). ## Description This PR reduces the individual fields of service configs to contain just `FrozenLayer`. This makes service configs work more seamlessly with runtime plugins in the orchestrator mode. Note that service config _builder_ s still contain individual fields. We're planning to make them just contain `aws_smithy_types::config_bag::Layer`. To do that, though, we need to make `Layer` cloneable and that will be handled in a separate PR. For builders, the only change you will in the PR is that their `build` method will put fields into a `Layer`, freeze it, and pass it to service configs. This PR is marked as a breaking change because it's based on [another PR](#2728) that's also breaking change. ## Testing - [x] Passed tests in CI ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: Yuki Saito <[email protected]> Co-authored-by: Zelda Hessler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This adds
TimeSourcein SDK and service configs so we can effectively control time when executing requests with the SDK at the client level.note: the breaking change is in a trait implementation of a struct we're going to delete, not a real breaking change
Description
SharedTimeSourceand use it in SdkConfig /aws-config/ ::ConfigSystemTime::now()that I could findTesting
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.