Allow "Update GitHub Pages" to opt-in to cargo sparse registry #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have run into an GitHub action failure within Update GitHub Pages, saying "usage of sparse registries requires `-Z sparse-registry`." This commit allows the action to opt-in to the sparse registry via an environment variable.
Velfi
approved these changes
Apr 20, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Co-authored-by: Zelda Hessler <[email protected]>
Velfi
approved these changes
Apr 20, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
added a commit
that referenced
this pull request
Apr 20, 2023
ysaito1001
added a commit
that referenced
this pull request
Apr 21, 2023
## Motivation and Context The previous attempt #2610 did not work for properly running the workflow for `Update GitHub Pages`. This PR reverts it and uses a different fix to address the issue. ## Description Possibly with [this](https://users.rust-lang.org/t/sparse-registry-breaking-my-ci-and-i-dont-understand-why/89976) and `dtolnaly/rust-toolchain` having fixed a couple of issues [related to the sparse registry](https://github.com/dtolnay/rust-toolchain/issues?q=is%3Aissue+is%3Aclosed+sparse) recently, this PR will use `dtolnaly/rust-toolchain@master` rather than `stable` (most CIs in this repository have been using `master`). ## Testing The workflow in question has been verified to run successfully with this change ([link](https://github.com/awslabs/smithy-rs/actions/runs/4758820036)). ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: Yuki Saito <[email protected]> Co-authored-by: John DiSanti <[email protected]>
unexge
pushed a commit
that referenced
this pull request
Apr 24, 2023
## Motivation and Context Addresses a CI failure within `Update GitHub Pages` due to the use of the cargo sparse registry ([example](https://github.com/awslabs/smithy-rs/actions/runs/4746548497/jobs/8430328515)). ## Description The PR allows the action to configure whether the cargo sparse registry is used via the environment variable [CARGO_UNSTABLE_SPARSE_REGISTRY](https://blog.rust-lang.org/2022/06/22/sparse-registry-testing.html#overview): <img width="800" alt="Screenshot 2023-04-20 at 11 55 06 AM" src="https://user-images.githubusercontent.com/15333866/233435686-d24ceb2f-facf-45c9-b6cb-490b8ea2b085.png"> ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: Yuki Saito <[email protected]> Co-authored-by: Zelda Hessler <[email protected]>
unexge
pushed a commit
that referenced
this pull request
Apr 24, 2023
## Motivation and Context The previous attempt #2610 did not work for properly running the workflow for `Update GitHub Pages`. This PR reverts it and uses a different fix to address the issue. ## Description Possibly with [this](https://users.rust-lang.org/t/sparse-registry-breaking-my-ci-and-i-dont-understand-why/89976) and `dtolnaly/rust-toolchain` having fixed a couple of issues [related to the sparse registry](https://github.com/dtolnay/rust-toolchain/issues?q=is%3Aissue+is%3Aclosed+sparse) recently, this PR will use `dtolnaly/rust-toolchain@master` rather than `stable` (most CIs in this repository have been using `master`). ## Testing The workflow in question has been verified to run successfully with this change ([link](https://github.com/awslabs/smithy-rs/actions/runs/4758820036)). ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: Yuki Saito <[email protected]> Co-authored-by: John DiSanti <[email protected]>
rcoh
pushed a commit
that referenced
this pull request
Apr 24, 2023
## Motivation and Context Addresses a CI failure within `Update GitHub Pages` due to the use of the cargo sparse registry ([example](https://github.com/awslabs/smithy-rs/actions/runs/4746548497/jobs/8430328515)). ## Description The PR allows the action to configure whether the cargo sparse registry is used via the environment variable [CARGO_UNSTABLE_SPARSE_REGISTRY](https://blog.rust-lang.org/2022/06/22/sparse-registry-testing.html#overview): <img width="800" alt="Screenshot 2023-04-20 at 11 55 06 AM" src="https://user-images.githubusercontent.com/15333866/233435686-d24ceb2f-facf-45c9-b6cb-490b8ea2b085.png"> ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: Yuki Saito <[email protected]> Co-authored-by: Zelda Hessler <[email protected]>
rcoh
pushed a commit
that referenced
this pull request
Apr 24, 2023
## Motivation and Context The previous attempt #2610 did not work for properly running the workflow for `Update GitHub Pages`. This PR reverts it and uses a different fix to address the issue. ## Description Possibly with [this](https://users.rust-lang.org/t/sparse-registry-breaking-my-ci-and-i-dont-understand-why/89976) and `dtolnaly/rust-toolchain` having fixed a couple of issues [related to the sparse registry](https://github.com/dtolnay/rust-toolchain/issues?q=is%3Aissue+is%3Aclosed+sparse) recently, this PR will use `dtolnaly/rust-toolchain@master` rather than `stable` (most CIs in this repository have been using `master`). ## Testing The workflow in question has been verified to run successfully with this change ([link](https://github.com/awslabs/smithy-rs/actions/runs/4758820036)). ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: Yuki Saito <[email protected]> Co-authored-by: John DiSanti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Addresses a CI failure within
Update GitHub Pagesdue to the use of the cargo sparse registry (example).Description
The PR allows the action to configure whether the cargo sparse registry is used via the environment variable CARGO_UNSTABLE_SPARSE_REGISTRY:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.