Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix codegen diff for codegen-client and codegen-server #2532

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Apr 3, 2023

Motivation and Context

codegen-diff broken for client/server

Description

  • extract constant strings to fix typo

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested review from a team as code owners April 3, 2023 17:25
@rcoh rcoh requested review from drganjoo and weihanglo April 3, 2023 17:25
@rcoh rcoh force-pushed the fix-codegen-diff branch from 6fd17e8 to ee14e4e Compare April 3, 2023 17:27
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python

A new doc preview is ready to view.

@rcoh rcoh added the needs-review A tag for PRs waiting on a review from one of the repo admins label Apr 3, 2023
@jdisanti jdisanti added this pull request to the merge queue Apr 3, 2023
@jdisanti jdisanti removed the needs-review A tag for PRs waiting on a review from one of the repo admins label Apr 3, 2023
Merged via the queue into main with commit 724ada8 Apr 3, 2023
@jdisanti jdisanti deleted the fix-codegen-diff branch April 3, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants