-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MSRV to 1.66.1 #2468
Update MSRV to 1.66.1 #2468
Conversation
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to change the default list of clippy lints in kotlin
Self::Md5 => Box::new(Md5::default()), | ||
Self::Sha1 => Box::new(Sha1::default()), | ||
Self::Sha256 => Box::new(Sha256::default()), | ||
Self::Crc32 => Box::<Crc32>::default(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol thanks clippy but that is definitely not better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm getting a bit annoyed at Clippy. The last few MSRV updates have introduced some really pedantic lints.
update: codegen clippy lint allowlist
A new generated diff is ready to view.
A new doc preview is ready to view. |
add: docs for aws-smithy-http add: docs for aws-smithy-client add: docs for aws-smithy-async
fix: lint name
A new generated diff is ready to view.
A new doc preview is ready to view. |
I had to fix several tests that were failing due to creating a module named "lib". Those changes need the most review. Affected modules are the structure and enum generator tests and a recursive struct test. |
If you approve this PR, then please merge it |
A new generated diff is ready to view.
A new doc preview is ready to view. |
@@ -109,13 +113,16 @@ impl SdkBody { | |||
} | |||
} | |||
|
|||
/// When an SdkBody is read, the inner data must be consumed. In order to do this, the SdkBody |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding docs!
Motivation and Context
#2467
Description
Updates the MSRV to 1.66.1
Testing
ran existing tests
Checklist
CHANGELOG.next.toml
if I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.toml
if I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.