Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: enable presigned S3 HeadObject requests #2451

Merged
merged 4 commits into from
Mar 13, 2023

Conversation

Velfi
Copy link
Contributor

@Velfi Velfi commented Mar 13, 2023

Motivation and Context

awslabs/aws-sdk-rust#753

Description

This add HeadObject to the list of S3 operations that support presigning.

Testing

I added a test.

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

CHANGELOG.next.toml Outdated Show resolved Hide resolved
@Velfi Velfi enabled auto-merge March 13, 2023 19:46
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python

A new doc preview is ready to view.

@Velfi Velfi added this pull request to the merge queue Mar 13, 2023
Copy link
Contributor

@ysaito1001 ysaito1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! s3::input::HeadObjectInput::builder() will probably need to be updated either in this PR or in #2433, depending on which PR is merged to main first.

Merged via the queue into main with commit 06b865b Mar 13, 2023
@Velfi Velfi deleted the update/enable-presigned-s3-headobject-requests branch March 13, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants