Add hook for CodegenDecorators to insert a custom symbol provider #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
reviewed
Mar 6, 2023
...ain/kotlin/software/amazon/smithy/rust/codegen/core/smithy/customize/CoreCodegenDecorator.kt
Outdated
Show resolved
Hide resolved
mcmasn-amzn
force-pushed
the
custom-derives
branch
from
a6c4592
to
a8025ae
Compare
|
I see all CI checks pass except 1, "CI (from fork) / ci / Check SDK Examples (pull_request) ". I don't understand the failure on this check. Is this related to my change? Or is it a known issue in this test?
|
rcoh
approved these changes
Mar 7, 2023
...ain/kotlin/software/amazon/smithy/rust/codegen/core/smithy/customize/CoreCodegenDecorator.kt
Outdated
Show resolved
Hide resolved
jdisanti
approved these changes
Mar 7, 2023
This failure isn't related to your PR, and won't block merging. |
|
cool, thank you for the review @jdisanti |
Velfi
pushed a commit
that referenced
this pull request
Apr 19, 2023
## Motivation and Context Follow-up to #2434 ## Description This provides a way to fix a compiler warning. Attributes created using RustMetadata.additionalAttributes may trigger compiler warnings (rust-lang/rust#79202) such as ``` warning: derive helper attribute is used before it is introduced --> src/model.rs:7674:3 | 7674 | #[serde(tag = "_type", content = "_content")] | ^^^^^ 7675 | #[derive( 7676 | serde::Deserialize, | ------------------ the attribute is introduced here | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #79202 <rust-lang/rust#79202> ``` ## Testing Added a unit test to validate the sort order is applied correctly to Attributes with isDeriveHelper = true. --------- Co-authored-by: david-perez <[email protected]>
unexge
pushed a commit
that referenced
this pull request
Apr 24, 2023
## Motivation and Context Follow-up to #2434 ## Description This provides a way to fix a compiler warning. Attributes created using RustMetadata.additionalAttributes may trigger compiler warnings (rust-lang/rust#79202) such as ``` warning: derive helper attribute is used before it is introduced --> src/model.rs:7674:3 | 7674 | #[serde(tag = "_type", content = "_content")] | ^^^^^ 7675 | #[derive( 7676 | serde::Deserialize, | ------------------ the attribute is introduced here | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #79202 <rust-lang/rust#79202> ``` ## Testing Added a unit test to validate the sort order is applied correctly to Attributes with isDeriveHelper = true. --------- Co-authored-by: david-perez <[email protected]>
rcoh
pushed a commit
that referenced
this pull request
Apr 24, 2023
## Motivation and Context Follow-up to #2434 ## Description This provides a way to fix a compiler warning. Attributes created using RustMetadata.additionalAttributes may trigger compiler warnings (rust-lang/rust#79202) such as ``` warning: derive helper attribute is used before it is introduced --> src/model.rs:7674:3 | 7674 | #[serde(tag = "_type", content = "_content")] | ^^^^^ 7675 | #[derive( 7676 | serde::Deserialize, | ------------------ the attribute is introduced here | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #79202 <rust-lang/rust#79202> ``` ## Testing Added a unit test to validate the sort order is applied correctly to Attributes with isDeriveHelper = true. --------- Co-authored-by: david-perez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#2158
Description
This provides a new hook on the
CoreCodegenDecoratorinterface. This allows authors of custom decorators (like myself) to manipulate symbols when they are being built.For example -- this allows me to insert extra derives (such as
serde::Deserialize).Testing
./gradlew testChecklist
No updates to changelog. This is an internal change that shouldn't affect most users.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.