Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: deprecation notice to deprecated fluent builder methods #2386

Merged
merged 3 commits into from
Feb 16, 2023
Merged

add: deprecation notice to deprecated fluent builder methods #2386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb28acb
add: deprecation notice to deprecated fluent builder methods
Velfi Feb 16, 2023
5798fbc
add: CHANGELOG.next.toml notes
Velfi Feb 16, 2023
94100af
Merge branch 'main' into add/deprecation-notices-to-fluent-builder-me…
Velfi Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGELOG.next.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,3 +210,15 @@ message = "Fix issue where clients using native-tls connector were prevented fro
references = ["aws-sdk-rust#736"]
meta = { "breaking" = false, "tada" = false, "bug" = true, "target" = "client" }
author = "Velfi"

[[aws-sdk-rust]]
message = "Fluent builder methods on the client are now marked as deprecated when the related operation is deprecated."
references = ["aws-sdk-rust#740"]
meta = { "breaking" = false, "tada" = true, "bug" = true }
author = "Velfi"

[[smithy-rs]]
message = "Fluent builder methods on the client are now marked as deprecated when the related operation is deprecated."
references = ["aws-sdk-rust#740"]
meta = { "breaking" = false, "tada" = true, "bug" = true, "target" = "client"}
author = "Velfi"
3 changes: 3 additions & 0 deletions ...tware/amazon/smithy/rust/codegen/client/smithy/generators/client/FluentClientGenerator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,9 @@ class FluentClientGenerator(
""",
)

// Write a deprecation notice if this operation is deprecated.
writer.deprecatedShape(operation)

writer.rust(
"""
pub fn ${
Expand Down