Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow @uniqueItems-constrained list shapes that reach a map shape #2375

Commits on Feb 15, 2023

  1. Disallow @uniqueItems-constrained list shapes that reach a map shape

    The server SDK codegen generates Rust code that does not compile when a
    `@uniqueItems`-constrained list shape reaches a map shape, essentially
    because `std::collections::HashMap` does not implement
    `std::hash::Hash`.
    
    A ticket with the Smithy team was opened in smithy-lang/smithy#1567 to
    disallow such models.
    
    This commit makes it so that codegen aborts with an informative message
    when such models are encountered, instead of going ahead and producing
    code that does not compile.
    
    This commit also slightly adjusts the error messages produced when
    unsupported constraint traits are found.
    david-perez committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    dac288d View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. ./gradlew ktlintFormat

    david-perez committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    8ca40e2 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/main' into davidpz/disallow-un…

    …ique-items-on-list-shapes-whose-closure-reaches-a-map-shape
    david-perez committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    407bad1 View commit details
    Browse the repository at this point in the history