Upgrade to Smithy 1.27.2 #2226
Merged
Upgrade to Smithy 1.27.2 #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velfi
approved these changes
Jan 18, 2023
jdisanti
reviewed
Jan 18, 2023
| @@ -405,12 +405,6 @@ pub(crate) mod rfc3339 { | |||
| // Timezones not supported: | |||
| // Not OK: 1985-04-12T23:20:50-02:00 | |||
| pub(crate) fn parse(s: &str) -> Result<DateTime, DateTimeParseError> { | |||
| if !matches!(s.chars().last(), Some('Z')) { | |||
There was a problem hiding this comment.
Was removing this intentional?
There was a problem hiding this comment.
yeah—Smithy changed their spec and now allows timezones
jdisanti
approved these changes
Jan 19, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
hlbarber
approved these changes
Jan 23, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jjant
reviewed
Feb 28, 2023
Comment on lines
410
to
411
| // | ||
| // Timezones not supported: |
There was a problem hiding this comment.
According to the comment below, this is outdated?
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Upgrade to smithy 1.27.1
Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.