Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @sparse constrained map shapes and list shapes #2213

Merged
merged 5 commits into from
Jan 17, 2023

Commits on Jan 13, 2023

  1. Support @sparse constrained map shapes and list shapes

    Turns out we've never supported them, neither directly constrained nor
    with constrained members, because of a lack of tests. Yet another data
    point to prioritize working on code-generating `constraints.smithy` (see
    #2101).
    
    The implementation is simple: we just need to call the symbol provider
    on the member symbols instead of on the target symbols so we get
    `Option<T>` list members / map values if applicable, and handle the
    wrapper when converting between unconstrained and constrained types with
    help from `match` and `Option<T>::map`.
    david-perez committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    6c835a6 View commit details
    Browse the repository at this point in the history
  2. Update changelog

    david-perez committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    15bf44d View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Configuration menu
    Copy the full SHA
    b4ae60f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5192742 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    76fd679 View commit details
    Browse the repository at this point in the history