refactor: RuntimeType creation and member resolution #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 6, 2022 15:47
refactor: RuntimeType companion functions add: AwsCargoDependency object refactor: move aws runtime crate fns into AwsRuntimeType update: all code affected by the above changes
rename: runtimeCrate to smithyRuntimeCrate remove: smithy prefix from RuntimeType
update: RuntimeType import
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
added 2 commits
December 7, 2022 10:22
rename: pascal-case functions to be camel-case
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
commented
Dec 7, 2022
jdisanti
approved these changes
Dec 7, 2022
ysaito1001
approved these changes
Dec 7, 2022
added 3 commits
December 8, 2022 09:13
…awslabs/smithy-rs into refactor/RuntimeType-and-AwsRuntimeType
fix: outdated doc comment
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the large PR
Motivation and Context
Maintainability and ease of use
Description
The short version:
RuntimeTypecreation and member resolutionRuntimeTypecompanion functionsAwsCargoDependencypackageAwsRuntimeTypeThe long version:
This PR implements the another part of #1933.
runtimeCratehas been renamed tosmithyRuntimeCrateand now requires users to pass the "smithy-" prefix as part of the crate name:before:
val smithyHttp = runtimeCrate("http").asType()after:
val smithyHttp = smithyRuntimeCrate("smithy-http").asType()awsRuntimeDependencyhas been renamed toawsRuntimeCratein order to matchsmithyRuntimeCrate.RuntimeTypes have all been consolidated into static methods and fields in theRuntimeTypecompanion object . AWS-specificRuntimeTypefunctions have been centralized insoftware.amazon.smithy.rustsdk.AwsRuntimeType.CargoDependencyandAwsCargoDependency. TheawsRuntimeCrate/smithyRuntimeCratefunctions still exist but you should avoid using them.Testing
Ran existing tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.