Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement @length on collections #2028

Merged
merged 56 commits into from
Nov 30, 2022
Merged

Implement @length on collections #2028

merged 56 commits into from
Nov 30, 2022

Commits on Nov 24, 2022

  1. Refactor ConstrainedMapGenerator slightly

    @jjant
    jjant committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    91ca287 View commit details
    Browse the repository at this point in the history

  2. Add @length list operation in constraints.smithy

    @jjant
    jjant committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    4e79202 View commit details
    Browse the repository at this point in the history

  3. Add more setup required for rendering constraint lists

    @jjant
    jjant committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    000175c View commit details
    Browse the repository at this point in the history

  4. Add initial draft of ConstrainedCollectionGenerator

    @jjant
    jjant committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    6299e29 View commit details
    Browse the repository at this point in the history

  5. Add license header to LengthTraitCommon

    @jjant
    jjant committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    617591d View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. Add draft of collection constraint violation generation 

    Copy `MapCostraintViolationGenerator` into
`CollectionConstraintViolationGenerator` for now.
    @jjant
    jjant committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    d0a6fab View commit details
    Browse the repository at this point in the history

  2. Add Visibility.toRustQualifier

    @jjant
    jjant committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    b71d1a9 View commit details
    Browse the repository at this point in the history

  3. Implement CollectionConstraintViolationGenerator

    @jjant
    jjant committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    e684ce7 View commit details
    Browse the repository at this point in the history

  4. Use TraitInfo on CollectionConstraintViolationGenerator

    @jjant
    jjant committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    c255474 View commit details
    Browse the repository at this point in the history

  5. Update docs on ConstrainedCollectionGenerator

    @jjant
    jjant committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    c109bb5 View commit details
    Browse the repository at this point in the history

  6. Improve formatting on rust code

    @jjant
    jjant committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    4ebc39a View commit details
    Browse the repository at this point in the history

  7. Don't generate ConstraintViolation enum twice

    @jjant
    jjant committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    eaa4e6f View commit details
    Browse the repository at this point in the history

  8. Make symbol provider work with constrained lists

    @jjant
    jjant committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    ba85018 View commit details
    Browse the repository at this point in the history

  9. Fix call to ConstraintViolation::Member

    @jjant
    jjant committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    94de917 View commit details
    Browse the repository at this point in the history

  10. Render constraint validation functions for lists

    @jjant
    jjant committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    b8b029f View commit details
    Browse the repository at this point in the history

  11. Fix call to usize::to_string

    @jjant
    jjant committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    8be886c View commit details
    Browse the repository at this point in the history

  12. Use map json customisation for collections as well

    @jjant
    jjant committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    e414189 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Merge branch 'main' into jjant/implement-length-trait-on-collections

    @jjant
    jjant authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    273d71c View commit details
    Browse the repository at this point in the history

  2. Update to use overhauled module system

    @jjant
    jjant committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6c50000 View commit details
    Browse the repository at this point in the history

  3. Add constraint traits check for collection shapes

    @jjant
    jjant committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    acc3c98 View commit details
    Browse the repository at this point in the history

  4. Remove test checking that @length is not used in lists

    @jjant
    jjant committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6c1a2c2 View commit details
    Browse the repository at this point in the history

  5. Refactor use of shape.isDirectlyConstrained

    @jjant
    jjant committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    c190d36 View commit details
    Browse the repository at this point in the history

  6. Fix failing UnconstrainedCollectionGeneratorTest test

    @jjant
    jjant committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    ad2d5e9 View commit details
    Browse the repository at this point in the history

  7. Fix test

    @jjant
    jjant committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    818477e View commit details
    Browse the repository at this point in the history

  8. Actually fix the test

    @jjant
    jjant committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    715f96b View commit details
    Browse the repository at this point in the history

  9. Update changelog

    @jjant
    jjant committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d2c59da View commit details
    Browse the repository at this point in the history

  10. Fix constrainedCollectionCheck

    @jjant
    jjant committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    2d22133 View commit details
    Browse the repository at this point in the history

  11. Add tests for ConstrainedCollectionGenerator

    @jjant
    jjant committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    1eb8650 View commit details
    Browse the repository at this point in the history

  12. Make tests work for when sets are implemented

    @jjant
    jjant committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    072df40 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Merge branch 'main' into jjant/implement-length-trait-on-collections

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    1a37a33 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into jjant/implement-length-trait-on-collections

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    3f906a2 View commit details
    Browse the repository at this point in the history

  3. Remove mention of set in changelog 

    Co-authored-by: david-perez <[email protected]>
    @jjant @david-perez
    jjant and david-perez authored Nov 29, 2022
    Configuration menu
    Copy the full SHA
    dfa3979 View commit details
    Browse the repository at this point in the history

  4. Fix styling in constraints.smithy 

    Co-authored-by: david-perez <[email protected]>
    @jjant @david-perez
    jjant and david-perez authored Nov 29, 2022
    Configuration menu
    Copy the full SHA
    925c225 View commit details
    Browse the repository at this point in the history

  5. Use check instead of assert

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    3b92790 View commit details
    Browse the repository at this point in the history

  6. Grammar fix in comment about Option<Box<_>>

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    bb24581 View commit details
    Browse the repository at this point in the history

  7. Rename unsupported length data class for blobs 

    - `UnsupportedLengthTraitOnCollectionOrOnBlobShape` -> `UnsupportedLengthTraitOnBlobShape`
    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    5cebcb9 View commit details
    Browse the repository at this point in the history

  8. Add TODO about uniqueItems not being implemented yet

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    074276a View commit details
    Browse the repository at this point in the history

  9. Change error message: unconstrained -> not constrained

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    28a3397 View commit details
    Browse the repository at this point in the history

  10. Add imports to fix docs

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    b0679c5 View commit details
    Browse the repository at this point in the history

  11. Remove unused modelsModuleWriter parameter

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    ebaa3f0 View commit details
    Browse the repository at this point in the history

  12. Use filterIsInstance and coalesce filter + map

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    0d5a313 View commit details
    Browse the repository at this point in the history

  13. Add check in json customization

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    ac2f737 View commit details
    Browse the repository at this point in the history

  14. Use Set instead of List for supported contraints

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    57cd6f1 View commit details
    Browse the repository at this point in the history

  15. Use toMutableList to avoid creating an extra list

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    964d78f View commit details
    Browse the repository at this point in the history

  16. Add @length list to ConA

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    838ada5 View commit details
    Browse the repository at this point in the history

  17. Add @httpQuery-bound @length list example

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    1e818e4 View commit details
    Browse the repository at this point in the history

  18. Add @httpHeader-bound @length list

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    111ee98 View commit details
    Browse the repository at this point in the history

  19. Fix UnconstrainedCollectionGeneratorTest test

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    a0e561e View commit details
    Browse the repository at this point in the history

  20. Fix rendering of constrained lists as header values

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    f759439 View commit details
    Browse the repository at this point in the history

  21. Split very long line

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    3f97e7c View commit details
    Browse the repository at this point in the history

  22. Add docs for ConstraintViolation::Member for lists

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    9e8c22b View commit details
    Browse the repository at this point in the history

  23. Merge branch 'main' into jjant/implement-length-trait-on-collections

    @jjant
    jjant committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    0bea362 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Pass length variable name to LengthTrait.rustCondition

    @jjant
    jjant committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    92ceba8 View commit details
    Browse the repository at this point in the history

  2. Refactor long conditional

    @jjant
    jjant committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    01cfe23 View commit details
    Browse the repository at this point in the history

  3. Homogenise conditional

    @jjant
    jjant committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    1ce32c8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into jjant/implement-length-trait-on-collections

    @jjant
    jjant authored Nov 30, 2022
    Configuration menu
    Copy the full SHA
    3b6932f View commit details
    Browse the repository at this point in the history