add: RFC for Supporting SelectObjectContent's unique ScanRange behavior
#2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
changed the title
SelectObjectContent's unique ScanRange behavior
jdisanti
reviewed
Nov 29, 2022
design/src/rfcs/rfc0024_supporting_select_object_content_scan_range.md
Outdated
Show resolved
Hide resolved
design/src/rfcs/rfc0024_supporting_select_object_content_scan_range.md
Outdated
Show resolved
Hide resolved
| Why this RFC should be rejected | ||
| ------------------------------- | ||
|
|
||
| There are several reasons to reject this RFC: |
There was a problem hiding this comment.
Another reason: In the unlikely event that S3 modifies ScanRange, the handwritten implementation will be out of sync.
design/src/rfcs/rfc0024_supporting_select_object_content_scan_range.md
Outdated
Show resolved
Hide resolved
Comment on lines
+198
to
+199
| We have already committed to supporting [IDLv2] and implementing that would allow users to set `start=0` or unset it. | ||
| Although IDLv2 support would NOT support the custom `end` value behavior, we'd be halfway there. Any future S3 |
There was a problem hiding this comment.
This is a little confusing because it seemed like the handwritten ScanRange implementation was to be applied to the IDLv2 implementation. But this sentence makes it seem like the ScanRange proposal is actually for an IDLv1 implementation?
Co-authored-by: John DiSanti <[email protected]>
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
I'm closing this since we've decided to handle this issue by implementing IDLv2 support instead. |
landonxjames
deleted the
rfc/supporting-SelectObjectContent-unique-ScanRange-behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
aws-smithy-sdk#630
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.