-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@range implementation for integer shapes #2005
Merged
Merged
Changes from 68 commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
42cddc8
Draft of @range implementation for integer shapes
LukeMathWalker bc62d0e
Green tests.
LukeMathWalker 53f5c59
Merge branch 'main' into range
LukeMathWalker 4e6db6b
Fix serialization of constrained integers.
LukeMathWalker 1c19bc7
Fix tagger to include Integer simple shapes.
LukeMathWalker 35148b1
Merge branch 'main' into range
LukeMathWalker cf72c16
Add range trait to the entry about constraint traits in our changelog.
LukeMathWalker 2cbe2a5
Bind a range-constrained integer to various HTTP parts to test our im…
LukeMathWalker 0ac5e66
Merge branch 'main' into range
LukeMathWalker f50b7b0
Rename ConstrainedIntGeneratorTest to ConstrainedIntegerGeneratorTest…
LukeMathWalker 0b80d2e
Remove AsRef implementation.
LukeMathWalker 2e77b8f
Fix constraints models.
LukeMathWalker 58c156f
Fix conversion.
LukeMathWalker a959004
Use ReturnSymbolToParse to dry up.
LukeMathWalker 3cc5e35
Fix builder when constrained types should not be exposed.
LukeMathWalker 1e9d6c7
Add customisation to unwrap constrained integers.
LukeMathWalker 22ff34f
Getting closer - collections need to be handled differently to make e…
LukeMathWalker 395c965
Refactor `renderHeaders`
LukeMathWalker a65f59d
Fix constraints test.
LukeMathWalker 250139d
Fix ebs.
LukeMathWalker 581162b
Rename for clarity.
LukeMathWalker d719328
Remove unnecessary From implementation.
LukeMathWalker 6e54c5e
Rename `Size` variant to `Range`.
LukeMathWalker d34a525
Remove stray comments.
LukeMathWalker 5762d2f
Rename for clarity
LukeMathWalker ea9bdac
Rename for consistency
LukeMathWalker 19297bc
Add test to guard against types for which we do not support range yet
LukeMathWalker 35dfb82
DRY up branches and the relevant tests.
LukeMathWalker 54e44c4
Merge branch 'main' into range
LukeMathWalker a94304f
Fix header name.
LukeMathWalker f36a617
Fix serialization bug for default values in headers.
LukeMathWalker c2773cd
Fix serialization issue for primitive headers.
LukeMathWalker f37a560
Remove SetOfRangeInteger
LukeMathWalker 5cd6d35
Fix pubcrateconstrained unit test.
LukeMathWalker 72cda3a
Remove duplication
LukeMathWalker 5c5c026
Merge branch 'main' into range
LukeMathWalker 6efc9b9
Revert "Remove SetOfRangeInteger"
LukeMathWalker 8359468
Reintroduce `SetOfRangeInteger`, but keep them commented out.
LukeMathWalker d36930d
Ignore leading whitespace.
LukeMathWalker dc0ef4b
Merge branch 'main' into range
LukeMathWalker 87e4766
Merge branch 'main' into range
LukeMathWalker 7328a9e
Merge branch 'main' into range
LukeMathWalker d259d86
Update codegen-core/src/main/kotlin/software/amazon/smithy/rust/codeg…
LukeMathWalker e2c5952
Update codegen-core/src/main/kotlin/software/amazon/smithy/rust/codeg…
LukeMathWalker 582de6d
Update codegen-server/src/main/kotlin/software/amazon/smithy/rust/cod…
LukeMathWalker 3f1bd70
Update codegen-server/src/test/kotlin/software/amazon/smithy/rust/cod…
LukeMathWalker 64e3312
Unify with a single rustTemplate invocation.
LukeMathWalker f927eaf
Rename `Type` to `NumberType`
LukeMathWalker 922d489
Update codegen-server/src/test/kotlin/software/amazon/smithy/rust/cod…
LukeMathWalker 563c1cc
Formatting issue.
LukeMathWalker 0ec9f13
Move and rename test helper.
LukeMathWalker f39669b
Dry up the logic for default serialization.
LukeMathWalker bdec811
Ooops, I swapped the two branches.
LukeMathWalker b2c4c9b
Merge main
LukeMathWalker 69c7b80
Add a wrapper block
LukeMathWalker 040eef6
Fix support detection.
LukeMathWalker b1787bb
Fix CHANGELOG.
LukeMathWalker 5141fa4
Add (failing) protocol tests for @range on byte/integer/long.
LukeMathWalker 50aa3b6
Fix validation message.
LukeMathWalker c9a7556
Mark some tests as expected to fail.
LukeMathWalker 3977b8c
Use ValueExpression everywhere for more granular control of the owner…
LukeMathWalker 2b31a14
Merge branch 'main' into range
LukeMathWalker 9ccad94
Use the new enhanced module facilities
LukeMathWalker 6024264
Fixes.
LukeMathWalker 1a884f6
Fix formatting
LukeMathWalker 48f8fb9
Remove unnecessary when.
LukeMathWalker fc3cf47
Update codegen-core/common-test-models/constraints.smithy
LukeMathWalker 28eae9c
Remove unused shapes.
LukeMathWalker 5b71893
Avoid mixing concerns in our test shapes for integer constraints.
LukeMathWalker 2211f3f
Reuse the trait info machinery
LukeMathWalker 28357fe
Update stale comment
LukeMathWalker 1d74bec
Fix unused attribute.
LukeMathWalker 374f839
Update codegen-core/src/main/kotlin/software/amazon/smithy/rust/codeg…
LukeMathWalker 2cf6141
Merge branch 'main' into range
LukeMathWalker 04ffdb7
Avoid unnecessary bindings by manipulating the serialization context …
LukeMathWalker a51e18a
Avoid unnecessary bindings in header serialization by introducing and…
LukeMathWalker 3160a92
Add code examples.
LukeMathWalker 7d4d59f
Move `safeName` call into the if branch.
LukeMathWalker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I'd use a
String
key here to not mix testing concerns. There should be tests exercising constrained strings on map keys.