Code

Implement @pattern on string shapes#1998

Code

Merged

jjant merged 64 commits intomainsmithy-lang/smithy-rs:mainfrom jjant/implement-length-trait-on-stringssmithy-lang/smithy-rs:jjant/implement-length-trait-on-stringsCopy head branch name to clipboardNov 23, 2022

+450-165

Commits

Commits on Nov 16, 2022

• Refactor ConstrainedStringGenerator to extract length checking

  jjant

  committed
  c45d0b0

  Copy full SHA for c45d0b0

Commits on Nov 17, 2022

• Extract TryFrom rendering into its own function

  jjant

  committed
  bc29310

  Copy full SHA for bc29310

• Extract ConstraintViolation definition to separate function

  jjant

  committed
  44495b9

  Copy full SHA for 44495b9

• Add pattern check mock for @pattern trait

  jjant

  committed
  e140694

  Copy full SHA for e140694

• Add regex to list of server dependencies

  jjant

  committed
  ae21ce7

  Copy full SHA for ae21ce7

• Use real regex check in check_pattern

  jjant

  committed
  4c6384d

  Copy full SHA for 4c6384d

• Add @pattern to traits that make string shapes directly constrained

  jjant

  committed
  c3e9659

  Copy full SHA for c3e9659

• Remove unsupported validation for @pattern on strings

  jjant

  committed
  b950c19

  Copy full SHA for b950c19

• Fix test cases in ConstraintsTest

  jjant

  committed
  b9206bf

  Copy full SHA for b9206bf

• Remove test disallowing @pattern on strings

  jjant

  committed
  1f3d763

  Copy full SHA for 1f3d763

• Add first test case for @pattern on strings

  jjant

  committed
  838485b

  Copy full SHA for 838485b

• Fix codegen in ConstraintViolation::as_validation_exception_field

  jjant

  committed
  1aa2573

  Copy full SHA for 1aa2573

• Use OnceCell to store @pattern's regex

  jjant

  committed
  d4de234

  Copy full SHA for d4de234

• Tidy up ConstrainedStringGenerator to work with many constraints

  jjant

  committed
  be24407

  Copy full SHA for be24407

• Rename handleTrait -> fromTrait and make it a static method

  jjant

  committed
  77637fd

  Copy full SHA for 77637fd

• Add docs for ConstraintViolation variants

  jjant

  committed
  aae0b75

  Copy full SHA for aae0b75

• Fix unescaped slashes in regexes

  jjant

  committed
  116e9de

  Copy full SHA for 116e9de

• Quick hack to get tests compiling

  jjant

  committed
  55df743

  Copy full SHA for 55df743

Commits on Nov 18, 2022

• Fix sensitive_string_display_implementation test

  jjant

  committed
  67863ca

  Copy full SHA for 67863ca

• Merge branch 'main' into jjant/implement-length-trait-on-strings

  jjant

  authored
  b4331cc

  Copy full SHA for b4331cc

• Use new fn name: asType -> toType

  jjant

  committed
  96ea2c7

  Copy full SHA for 96ea2c7

• Refactor ConstrainedStringGenerator to not pass in constraints

  jjant

  committed
  275e2a8

  Copy full SHA for 275e2a8

• Add @pattern test

  jjant

  committed
  4ffd550

  Copy full SHA for 4ffd550

• Use Lazy instead of OnceCell

  jjant

  committed
  0797f4d

  Copy full SHA for 0797f4d

• Store &'static str in Pattern error instead of String

  jjant

  committed
  22fd18f

  Copy full SHA for 22fd18f

• Move TraitInfo to the bottom

  jjant

  committed
  65139bd

  Copy full SHA for 65139bd

• Extract branches in TraitInfo.fromTrait into separate functions

  jjant

  committed
  d26a877

  Copy full SHA for d26a877

• Add PatternTrait.validationErrorMessage

  jjant

  committed
  0d7bbee

  Copy full SHA for 0d7bbee

• Add more tests for @pattern

  jjant

  committed
  85ddc4c

  Copy full SHA for 85ddc4c

• Merge branch 'main' into jjant/implement-length-trait-on-strings

  jjant

  committed
  e8b47a2

  Copy full SHA for e8b47a2

• Add entry to CHANGELOG.next.toml

  jjant

  committed
  a6ad449

  Copy full SHA for a6ad449

• Fix a @length + @pattern test case

  jjant

  committed
  8ade3a1

  Copy full SHA for 8ade3a1

Commits on Nov 21, 2022

• Remove unused binding in ConstrainedStringGeneratorTest

  jjant

  committed
  961e3af

  Copy full SHA for 961e3af

• Remove calls to trimIndent

  jjant

  committed
  8a1f73f

  Copy full SHA for 8a1f73f

• Use raw Rust strings instead of escapedPattern

  jjant

  committed
  1f02303

  Copy full SHA for 1f02303

• Require regex 1.5.5 instead of 1.7.0

  jjant

  committed
  dcd2528

  Copy full SHA for dcd2528

• Use Writables in TraitInfo

  jjant

  committed
  d90f447

  Copy full SHA for d90f447

• Use single rust call for impl $name block

  jjant

  committed
  78d6512

  Copy full SHA for 78d6512

• Move supportedStringConstraintTraits to Constraints.kt

  jjant

  committed
  4234b6d

  Copy full SHA for 4234b6d

• Fix error message mentioning wrong ignoreUnsupportedConstraintTraits key

  jjant

  committed
  abaf910

  Copy full SHA for abaf910

• Fix usage of :W in rustTemplate and raw Rust strings

  jjant

  committed
  46b126b

  Copy full SHA for 46b126b

• Use shorthand form for PatternTrait.validationErrorMessage

  jjant

  committed
  d551168

  Copy full SHA for d551168

• Fix protocol tests by adjusting the validation message

  jjant

  committed
  76e5984

  Copy full SHA for 76e5984

• Add uses of @pattern in constraints.smithy model

  jjant

  committed
  227ddaf

  Copy full SHA for 227ddaf

• Merge branch 'main' into jjant/implement-length-trait-on-strings

  jjant

  authored
  147af6b

  Copy full SHA for 147af6b

• Fix broken RestJsonMalformedPatternReDOSString test

  jjant

  committed
  e89850f

  Copy full SHA for e89850f

• Move TraitInfo to its own module and separate string-specific details

  jjant

  committed
  995bf0f

  Copy full SHA for 995bf0f

Commits on Nov 22, 2022

• Update codegen-core/common-test-models/constraints.smithy

  Show description for 3e45b9e
  

  jjant

  and

  david-perez

  authored
  3e45b9e

  Copy full SHA for 3e45b9e

• Fix nits in constraints.smithy

  jjant

  committed
  309423f

  Copy full SHA for 309423f

• Add license to TraitInfo.kt

  jjant

  committed
  7a95fe2

  Copy full SHA for 7a95fe2

• Merge branch 'jjant/implement-length-trait-on-strings' of github.com:awslabs/smithy-rs into jjant/implement-length-trait-on-strings

  jjant

  committed
  7f5e68f

  Copy full SHA for 7f5e68f

• Make StringTraitInfo.fromTrait not return a nullable

  jjant

  committed
  bbb1b81

  Copy full SHA for bbb1b81

• Remove overzealous formatting

  jjant

  committed
  fdcd2b7

  Copy full SHA for fdcd2b7

• Add some padding to json in fixRestJsonMalformedPatternReDOSString

  jjant

  committed
  4a06c77

  Copy full SHA for 4a06c77

• Add compile_regex function for @pattern strings

  jjant

  committed
  750e49d

  Copy full SHA for 750e49d

• Add helpful error message when regexes fail to compile

  jjant

  committed
  11ee326

  Copy full SHA for 11ee326

• Add missing coverage in constraints.smithy

  jjant

  committed
  cb4d4ee

  Copy full SHA for cb4d4ee

Commits on Nov 23, 2022

• Fix examples in constraints.smithy

  jjant

  committed
  be4a85a

  Copy full SHA for be4a85a

• Fix failing test

  jjant

  committed
  105112a

  Copy full SHA for 105112a

• Combine writables in ConstrainedStringGenerator

  jjant

  committed
  0d2b6b6

  Copy full SHA for 0d2b6b6

• Fix uses of Writable.join

  jjant

  committed
  3848d34

  Copy full SHA for 3848d34

• Use expect over unwrap_or_else

  jjant

  committed
  fdf88b0

  Copy full SHA for fdf88b0

• Use once_cell::sync::Lazy over once_cell::sync::OnceCell

  jjant

  committed
  53cf34c

  Copy full SHA for 53cf34c

• Merge branch 'main' into jjant/implement-length-trait-on-strings

  jjant

  committed
  7a2576c

  Copy full SHA for 7a2576c