Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render full shape IDs in server error responses #1982

Merged

Commits on Nov 14, 2022

  1. Render full shape IDs in server error responses

    RestJson1 implementations can denote errors in responses in several
    ways. New server-side protocol implementations MUST use a header field
    named `X-Amzn-Errortype`.
    
    Note that the spec says that implementations SHOULD strip the error
    shape ID's namespace. However, our server implementation renders the
    full shape ID (including namespace), since some existing clients rely on
    it to deserialize the error shape and fail if only the shape name is
    present. This is compliant with the spec, see
    smithy-lang/smithy#1493.
    
    See smithy-lang/smithy#1494 too.
    david-perez committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    9870522 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Merge remote-tracking branch 'upstream/main' into davidpz/dont-strip-…

    …namespace-from-restJson1-error-responses
    david-perez committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    b1e800c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a615a8 View commit details
    Browse the repository at this point in the history