Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always write required query param keys, even if value is unset or empty #1973

Merged
merged 20 commits into from
Nov 18, 2022
Merged

Always write required query param keys, even if value is unset or empty #1973

merged 20 commits into from
Nov 18, 2022

Commits on Nov 9, 2022

  1. fix: issues when sending multipart-upload-related operations with no … 

    …upload ID by making upload ID required

add: Mandatory trait
add: S3 customization to make Upload Ids mandatory
    @Velfi
    Velfi committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    67baf66 View commit details
    Browse the repository at this point in the history

  2. add: CHANGELOG.next.toml entry

    @Velfi
    Velfi committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    3179154 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. update: strategy for tagging shapes as mandatory

    @Velfi
    Velfi committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    12afb30 View commit details
    Browse the repository at this point in the history

  2. remove: Mandatory trait 

    undo: S3Decorator changes
add: codegen to generate "else" branch after required query string serialization `if let Some` check
add: missing tokio feature to `TokioTest`
    @Velfi
    Velfi committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    98b6b9e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/abort-multipart-upload-bug

    @Velfi
    Velfi authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    1d42998 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. update: mandatory-query-param.rs tests

    @Velfi
    Velfi committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    d3067ae View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/abort-multipart-upload-bug

    @Velfi
    Velfi authored Nov 14, 2022
    Configuration menu
    Copy the full SHA
    3e30f27 View commit details
    Browse the repository at this point in the history

  3. format: run cargo fmt

    @Velfi
    Velfi committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    23c5ca3 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. update: return BuildError for missing required query params 

    update: required-query-params.rs tests
    @Velfi
    Velfi committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    339c547 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/abort-multipart-upload-bug

    @Velfi
    Velfi authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    b8d26c6 View commit details
    Browse the repository at this point in the history

  3. formatting: make RustWriter.paramList more readable 

    fix: code broken by merge from `main`
    @Velfi
    Velfi committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    27e8e8c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix/abort-multipart-upload-bug

    @Velfi
    Velfi authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    fccd34e View commit details
    Browse the repository at this point in the history

  5. fix: handling of enum strings

    @Velfi
    Velfi committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    5e64807 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into fix/abort-multipart-upload-bug

    @Velfi
    Velfi authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    d473223 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. add: codegen tests for required query params 

    update: required enum query param codegen
add: smithy-rs CHANGELOG.next.toml entry
    @Velfi
    Velfi committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    d277416 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/abort-multipart-upload-bug

    @Velfi
    Velfi authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    6282760 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. fix: presigning.rs test

    @Velfi
    Velfi committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    7adc4c6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/abort-multipart-upload-bug

    @Velfi
    Velfi committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    156a172 View commit details
    Browse the repository at this point in the history

  3. fix: use toType instead of asType 

    fix: indentation in test
    @Velfi
    Velfi committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    2abb406 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix/abort-multipart-upload-bug

    @Velfi
    Velfi authored Nov 18, 2022
    Configuration menu
    Copy the full SHA
    e552da6 View commit details
    Browse the repository at this point in the history