Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin derive_arbitrary version #1887

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Pin derive_arbitrary version #1887

merged 1 commit into from
Oct 21, 2022

Conversation

jdisanti
Copy link
Collaborator

Motivation and Context

Version 1.2.0 of derive_arbitrary requires Rust 1.63, so we need to pin the version to the previous release since our MSRV is 1.62.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti jdisanti requested a review from a team as a code owner October 20, 2022 22:20
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@david-perez
Copy link
Contributor

We need to update CODEOWNERS. Server team is currently not being added as reviewer to this PR because we're only marked as owners of aws-smithy-http-server, but in reality any change to most crates under rust-runtime/ (like aws-smithy-eventstream) is depended upon by server SDKs.

david-perez added a commit that referenced this pull request Oct 21, 2022
These crates are used by server SDKs too. `CODEOWNERS` currently says
they are exclusively owned by the AWS Rust SDK team.

See #1887 (comment).
david-perez added a commit that referenced this pull request Oct 21, 2022
These crates are used by server SDKs too. `CODEOWNERS` currently says
they are exclusively owned by the AWS Rust SDK team.

See #1887 (comment).
@Velfi Velfi merged commit 03b8347 into main Oct 21, 2022
@Velfi Velfi deleted the jdisanti-pin-derive-arbitrary branch October 21, 2022 14:40
david-perez added a commit that referenced this pull request Oct 25, 2022
These crates are used by server SDKs too. `CODEOWNERS` currently says
they are exclusively owned by the AWS Rust SDK team.

See #1887 (comment).
aws-sdk-rust-ci pushed a commit to awslabs/aws-sdk-rust that referenced this pull request Dec 14, 2022
…1889)

These crates are used by server SDKs too. `CODEOWNERS` currently says
they are exclusively owned by the AWS Rust SDK team.

See smithy-lang/smithy-rs#1887 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants