Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an Unhandled error new-type #1849

Merged
merged 3 commits into from
Nov 11, 2022
Merged

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Oct 13, 2022

Motivation and Context

This PR implements an Unhandled error new-type for RFC-0022: Error Context and Compatibility.

This PR is part of a series that will fully implement the RFC, tracked in #1926.

Changelog entries added in #1951.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti jdisanti requested review from a team as code owners October 13, 2022 17:21
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti jdisanti force-pushed the jdisanti-display-error-context branch from 0344c0f to 308b419 Compare October 21, 2022 18:06
@jdisanti jdisanti force-pushed the jdisanti-unhandled-error-newtype branch 2 times, most recently from 1b90d4c to ea102d4 Compare October 21, 2022 18:37
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti jdisanti force-pushed the jdisanti-display-error-context branch from 308b419 to 9b2bd36 Compare October 28, 2022 22:42
@jdisanti jdisanti force-pushed the jdisanti-unhandled-error-newtype branch from ea102d4 to b3a2b6c Compare October 28, 2022 22:43
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti jdisanti marked this pull request as draft October 31, 2022 20:04
@jdisanti jdisanti force-pushed the jdisanti-display-error-context branch from 9b2bd36 to 73aaf5f Compare November 2, 2022 20:38
@jdisanti jdisanti force-pushed the jdisanti-unhandled-error-newtype branch from b3a2b6c to bd16b5d Compare November 2, 2022 20:41
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

Base automatically changed from jdisanti-display-error-context to main November 4, 2022 21:09
@jdisanti jdisanti marked this pull request as ready for review November 4, 2022 21:09
@jdisanti jdisanti force-pushed the jdisanti-unhandled-error-newtype branch from cd90022 to a15055e Compare November 4, 2022 21:12
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link
Contributor

@crisidev crisidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a breaking change right? Are you planning to add all the CHANGELOG entries later on?

@jdisanti
Copy link
Collaborator Author

jdisanti commented Nov 9, 2022

This is a breaking change right? Are you planning to add all the CHANGELOG entries later on?

The changelog entries added in #1951, which basically links off to some issues. I'm writing up the full change notes for the entire series of PRs.

@jdisanti jdisanti force-pushed the jdisanti-unhandled-error-newtype branch from a15055e to 00fa06a Compare November 11, 2022 00:05
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti jdisanti merged commit 154dffd into main Nov 11, 2022
@jdisanti jdisanti deleted the jdisanti-unhandled-error-newtype branch November 11, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants