Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression: Use connect_timeout and read_timeout again (#1822) #1823

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Fix regression: Use connect_timeout and read_timeout again (#1822) #1823

merged 2 commits into from
Oct 7, 2022

Conversation

kevinpark1217
Copy link
Contributor

@kevinpark1217 kevinpark1217 commented Oct 6, 2022

Motivation and Context

For #1822
@jdisanti

Description

Testing

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kevinpark1217 kevinpark1217 requested a review from a team as a code owner October 6, 2022 22:42
Copy link
Collaborator

@jdisanti jdisanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you!

Please add a [[aws-sdk-rust]] entry to CHANGELOG.next.toml.

@kevinpark1217 kevinpark1217 requested a review from a team as a code owner October 6, 2022 23:19
@kevinpark1217
Copy link
Contributor Author

Good catch! Thank you!

Please add a [[aws-sdk-rust]] entry to CHANGELOG.next.toml.

Done!

@jdisanti jdisanti enabled auto-merge (squash) October 6, 2022 23:40
@jdisanti jdisanti merged commit e78da55 into smithy-lang:main Oct 7, 2022
@kevinpark1217 kevinpark1217 deleted the fix_regression branch October 17, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants