Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-smithy-http-tower: Lower log level of two info logs. #1735

Merged
merged 2 commits into from
Sep 19, 2022
Merged

aws-smithy-http-tower: Lower log level of two info logs. #1735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33932a3
aws-smithy-http-tower: Lower log level of two info logs.
vojtechkral Sep 15, 2022
4a4c195
Merge branch 'main' into aws-smithy-http-tower-log-level
jdisanti Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.next.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@
# meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client | server | all"}
# author = "rcoh"

[[smithy-rs]]
message = "Lower log level of two info-level log messages."
references = ["smithy-rs#1735"]
meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client" }
author = "vojtechkral"

[[aws-sdk-rust]]
message = "`aws_config::RetryConfig` no longer implements `Default`, and its `new` function has been replaced with `standard`."
references = ["smithy-rs#1603", "aws-sdk-rust#586"]
Expand Down
2 changes: 1 addition & 1 deletion rust-runtime/aws-smithy-client/src/retry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ impl RetryHandler {
sleep_future.await;
next
}
.instrument(tracing::info_span!("retry", kind = &debug(retry_kind)));
.instrument(tracing::debug_span!("retry", kind = &debug(retry_kind)));
Some(check_send(Box::pin(fut)))
}
}
Expand Down
4 changes: 2 additions & 2 deletions rust-runtime/aws-smithy-http-tower/src/parse_response.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use std::pin::Pin;
use std::task::{Context, Poll};
use tower::{Layer, Service};
use tracing::field::display;
use tracing::{debug_span, field, info_span, Instrument};
use tracing::{debug_span, field, Instrument};

/// `ParseResponseService` dispatches [`Operation`](aws_smithy_http::operation::Operation)s and parses them.
///
Expand Down Expand Up @@ -92,7 +92,7 @@ where
let handler = parts.response_handler;
// send_operation records the full request-response lifecycle.
// NOTE: For operations that stream output, only the setup is captured in this span.
let span = info_span!(
let span = debug_span!(
"send_operation",
operation = field::Empty,
service = field::Empty,
Expand Down