Endpoint params #1683
Merged
Endpoint params #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Aug 30, 2022
| rustTemplate( | ||
| """ | ||
| /// Sets the value for $name #{extraDocs:W} | ||
| pub fn $name(mut self, value: #{type}) -> Self { |
There was a problem hiding this comment.
Should this setter also use impl Into<#{nonOptionalType}>?
There was a problem hiding this comment.
ah—I didn't do that because it makes editors get super confused and not show good hints.
rcoh
added a commit
that referenced
this pull request
Sep 6, 2022
* Add endpoint parameter generator * Switch to git dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This adds generation of the
EndpointParamsstruct from endpoint rules. This is the first of a series of PRs to thefeature/endpointsbranch. This uses asourcedependency to avoid the need to manually publishToMavenLocal. Prior to merging to mainline, we will need to finalize the Ruleset changes in a smithy release and remove the source override.Description
Testing
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.