Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI by pinning version of arbitrary #1681

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Fix CI by pinning version of arbitrary #1681

merged 1 commit into from
Aug 30, 2022

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Aug 29, 2022

Motivation and Context

The arbitrary crate that we use in some of our fuzz tests started using array::from_fn, which is only stable as of Rust 1.63. The arbitrary crate has no intention of supporting any Rust version other than the latest stable. Since our MSRV is 1.61, this causes our Rust runtime tests to fail to compile. This PR resolves the issue by pinning the arbitrary crate to the last version that successfully compiles against Rust 1.61. This should be fine since it's only needed for tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti jdisanti requested a review from a team as a code owner August 29, 2022 23:12
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@Velfi Velfi merged commit 2bcf4da into main Aug 30, 2022
@Velfi Velfi deleted the jdisanti-fix-arbitrary branch August 30, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants