Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten and remove mixins from code generation #1680

Merged
merged 14 commits into from
Sep 6, 2022
+141 −4
Merged

Flatten and remove mixins from code generation #1680

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
000bbb7
Very naive way of attempting to apply mixins.
DavidOgunsAWS Aug 29, 2022
617063a
Format
DavidOgunsAWS Aug 29, 2022
42fabb2
Added logic to baseline transform instead.
DavidOgunsAWS Aug 29, 2022
d5a5104
Add baseline transform to client codegen as well.
DavidOgunsAWS Aug 29, 2022
408734f
WIP -- improve asSmithyModel for IDLv2. Need to add same unit test fo…
DavidOgunsAWS Aug 30, 2022
8882d08
Improved asSmithyModel function to accept Smithy version. Renamed tes…
DavidOgunsAWS Aug 31, 2022
9fadcb7
WIP -- test pass. ktlint issue needs fixed.
DavidOgunsAWS Aug 31, 2022
c83b0e9
Organized imports using InteliJ
DavidOgunsAWS Aug 31, 2022
b442b36
Updated changelog next.
DavidOgunsAWS Aug 31, 2022
687dc93
Add internal test access to baseline transform in ServerCodegenVisitor.
DavidOgunsAWS Sep 1, 2022
2102a3b
Fix invalid subproject generated by added tests messing up other tests.
DavidOgunsAWS Sep 2, 2022
8cc1213
PR comment improvement.
DavidOgunsAWS Sep 5, 2022
9a60dcc
Removing unneeded part of fix.
DavidOgunsAWS Sep 6, 2022
8961211
ktlint
DavidOgunsAWS Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated changelog next.
@DavidOgunsAWS
DavidOgunsAWS committed Sep 6, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit b442b3649bc3c744c9da84914f7c700a9bd5dbe1
7 changes: 6 additions & 1 deletion CHANGELOG.next.toml
View file
Original file line number Diff line number Diff line change
@@ -73,7 +73,6 @@ references = ["smithy-rs#1603", "aws-sdk-rust#586"]
meta = { "breaking" = true, "tada" = false, "bug" = false, "target" = "client" }
author = "jdisanti"


[[aws-sdk-rust]]
message = """
Implemented customizable operations per [RFC-0017](https://awslabs.github.io/smithy-rs/design/rfcs/rfc0017_customizable_client_operations.html).
@@ -169,3 +168,9 @@ let response = client.some_operation()
references = ["smithy-rs#1647", "smithy-rs#1112"]
meta = { "breaking" = false, "tada" = true, "bug" = false, "target" = "client"}
author = "Velfi"

[[smithy-rs]]
message = "Smithy IDL v2 mixins are now supported"
references = ["smithy-rs#1680"]
meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "all"}
author = "ogudavid"