Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the check manifests tool #1576

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Fix the check manifests tool #1576

merged 2 commits into from
Jul 26, 2022

Conversation

jdisanti
Copy link
Collaborator

Motivation and Context

CI on PRs in aws-sdk-rust are failing due to:

      Running `/home/runner/work/aws-sdk-rust/aws-sdk-rust/smithy-rs/tools/target/debug/publisher fix-manifests --check --location ../../../sdk`
2022-07-26T00:37:57.281962Z  INFO publisher::subcommand::fix_manifests::validate: Pre-validation manifests...
Error: Crate named `aws-sdk-accessanalyzer` should be at version `0.46.0` but is at `0.16.0`
Error: Process completed with exit code 1.

This PR updates the publisher tool's validation to no longer assume that all SDK crates have the same version number.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti jdisanti requested a review from a team as a code owner July 26, 2022 17:01
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti jdisanti enabled auto-merge (squash) July 26, 2022 17:54
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti jdisanti merged commit 2670831 into main Jul 26, 2022
@jdisanti jdisanti deleted the jdisanti-fix-check-manifests branch July 26, 2022 19:06
lkts pushed a commit to lkts/smithy-rs that referenced this pull request Jul 26, 2022
lkts pushed a commit to lkts/smithy-rs that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants