Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simple model error #1507

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Fix simple model error #1507

merged 1 commit into from
Jun 28, 2022

Conversation

crisidev
Copy link
Contributor

Description

Fix the error

DANGER: com.amazonaws.simple#StoreServiceBlob (HttpMethodSemantics)
     @ /home/ANT.AMAZON.COM/matbigoi/github/smithy-rs/codegen-server-test/python/model/simple.smithy
     |
 111 | @http(method: "GET", uri: "/service/{id}/blob")
     |       ^
     = This operation uses the `GET` method in the `http` trait, but the `content` member is sent as the payload of the request because it is marked with the `httpPayload` trait. Many HTTP clients do not support payloads with GET requests. Consider binding this member to other parts of the HTTP request such as a query string parameter using the `httpQuery` trait, a header using the `httpHeader` trait, or a path segment using the `httpLabel` trait.

This is a fix to prevent issue with the Python generation. However, the root cause is still unknown: #1489

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…it, but the member is sent as the payload'

Signed-off-by: Bigo <[email protected]>
@crisidev crisidev added the server Rust server SDK label Jun 28, 2022
@crisidev crisidev requested a review from a team as a code owner June 28, 2022 12:26
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@crisidev crisidev merged commit 149b92b into main Jun 28, 2022
@crisidev crisidev deleted the matbigoi/fix-simple-model branch June 28, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Rust server SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants